1120086 - MSE: Transition from MediaSource::readyState "ended" to "open" can't happen

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

As per spec:
http://w3c.github.io/media-source/#sourcebuffer-prepare-append

"
4.If the readyState attribute of the parent media source is in the "ended" state then run the following steps:

   1.Set the readyState attribute of the parent media source to "open"
   2.Queue a task to fire a simple event named sourceopen at the parent media source .
"

readyState is in the "ended" state if endOfStream() was called.
However, endOfStream() will call SourceBuffer::Ended() which in turns call:
mTrackBuffer->DiscardDecoder() which will clear mCurrentDecoder.

Subsequent calls to SourceBuffer::appendBuffer will fail, as the current decoder in the track buffer has been cleared:

TrackBuffer::AppendDataToCurrentResource(const uint8_t* aData, uint32_t aLength)
{
  MOZ_ASSERT(NS_IsMainThread());
  if (!mCurrentDecoder) {
    return false;
  }

If endOfStream was called without an error; the TrackBuffer's current decoder shouldn't be discarded.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Re-open SourceBuffer after call to appendBuffer if in ended state

Allow readyState transition from ended to open.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Update w3c web reference tests

Update test results. We won't fail the test anymore

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Update w3c web reference tests

Update test results. We won't fail the test anymore

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8547481 [details] [diff] [review]
Update w3c web reference tests

Actually, this test was required by another fix in bug 1120075

Comment 5

[Jean-Yves Avenard [:jya]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f1d37b792c4a

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8547250 [details] [diff] [review]
Re-open SourceBuffer after call to appendBuffer if in ended state

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to use Flash for video.
[Describe test coverage new/current, TBPL]: stable on inbound. presuming green on m-c.
[Risks and why]: MSE-specific, so low.
[String/UUID change made/needed]: None.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f1d37b792c4a

Comment 8

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/53345874560b

Comment 9

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7dd701f60492