Closed
Bug 1120960
Opened 9 years ago
Closed 9 years ago
Remove NativeObject::lookup workaround for MSVC bug
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
977 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
NativeObject::lookup is MOZ_NEVER_INLINE with MSVC to work around a VS 2008/2010 compiler bug, see bug 718541. We require VS 2013 now, there have been a ton of changes to the code and I don't see any crashes with the workaround removed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c66566248569
Attachment #8548220 -
Flags: review?(jwalden+bmo)
|
||
Updated•9 years ago
|
Attachment #8548220 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 1•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d60a0e201e2c
|
||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d60a0e201e2c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•