1121064 - Remove dormant dependent status change from MediaDecoder::SetDormantIfNecessary()

Status: RESOLVED WONTFIX

(Core :: Audio/Video, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

Since Bug 1108728 fix, dormant specific status was removed from MediaDecoder. But MediaDecoder::SetDormantIfNecessary() is still doing dormant dependent status change to MediaDecoder. It is necessary to be removed from MediaDecoder.

Comment 1

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> Since Bug 1108728 fix, dormant specific status was removed from
> MediaDecoder. But MediaDecoder::SetDormantIfNecessary() is still doing
> dormant dependent status change to MediaDecoder. It is necessary to be
> removed from MediaDecoder.

When the status change is simply removed from MediaDecoder::SetDormantIfNecessary(), the following redundant function calls during resuming from dormant cause incorrect state transition.
- MediaDecoder::FirstFrameLoaded()
- MediaDecoder::SeekingStoppedAtEnd()
- MediaDecoder::SeekingStopped()

Comment 2

[Sotaro Ikeda [:sotaro]]

After some investigations, I recognized that MediaDecoder could not be independent from dormant state of MediaDecoderStateMachine. When MediaDecoderStateMachine is in dormant state, MediaDecoder can not change it's state ChangeState(PLAY_STATE_LOADING) realize it. Until file is loaded again, MediaDecoder::mNextState stores status change.

Comment 3

[Sotaro Ikeda [:sotaro]]

Set to WONTFIX based on Comment 2.