1121162 - leakchecks become permaorange when async plugin init is turned on

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Failures such as the one in bug 1064197 occur regularly in M1 and M3 (non-e10s) when running tests with Asynchronous Plugin Initialization turned on by default. This is actually pretty bizarre given that those leaked objects are not plugin-related.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Resume stream listener before destroying it

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=063f36034ae1

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0c7de37b32

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fe0c7de37b32

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8555386 [details] [diff] [review]
Resume stream listener before destroying it

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: Will not have the option to ship asyncInit in 37
[Describe test coverage new/current, TreeHerder]: On m-c and locally. Tests that previously leaked with asyncInit turned on now pass.
[Risks and why]: None, trivial fix
[String/UUID change made/needed]: None

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking as this impacts shipping asyncInit.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8555386 [details] [diff] [review]
Resume stream listener before destroying it

Aurora+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c785bf627bac