1121373 - "Other month" day label in month view have a different color

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Decathlon]

In month view, the font for the day labels inside the day boxes that belong to the other month have a darker color.

Comment 1

[Decathlon]

Attachment: patch - v1

The patch should fix.
I've also added a rule about the background color of the label when the day is "other-month", "day-off" and selected that seems missing since ever.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8548748 [details] [diff] [review]
patch - v1

Review of attachment 8548748 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, --viewMonthDayOtherColor is not really needed.

r- now, because of the two comments.

::: calendar/base/themes/common/calendar-views.css
@@ +601,1 @@
>      background-color: var(--viewMonthDayOtherLabelBackground);

When you remove the var here, please check if this var is still used. Actually --viewMonthDayOtherColor is no more used and you can also remove the variable definitions.

@@ +632,1 @@
>      background-color: var(--viewMonthDayBoxSelectedBackground);

Please don't remove this variable as for the systemcolors it needs the correct color to match the background color. Linux has on some themes weird highlight background colors and without the matching text color it can be unreadable.

Instead of removing the variable please set the color of --viewMonthDayBoxLabelColor for the --viewMonthDayBoxSelectedColor in normal color variable set (#616163).

Comment 3

[Decathlon]

Attachment: patch - v2

I can't verify the part about Linux, is it correct in this way?

I've also noticed that the background color of the label for "today" when systemcolors are active is different than before the introduction of the css variables (now is Highlight, before it was absent).
Looks like it needs a different variable for the background in the rule
.calendar-month-day-box-date-label[relation="today"][selected="true"]
in order to have the possibility to differentiate the background in the systemcolors case.
What do you think?

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8549949 [details] [diff] [review]
patch - v2

Looks good now. r+

(In reply to Decathlon from comment #3)
> 
> I've also noticed that the background color of the label for "today" when
> systemcolors are active is different than before the introduction of the css
> variables (now is Highlight, before it was absent).
> Looks like it needs a different variable for the background in the rule
> .calendar-month-day-box-date-label[relation="today"][selected="true"]
> in order to have the possibility to differentiate the background in the
> systemcolors case.
> What do you think?

Good catch, before, systemcolors has set the color and now it's the background color. I file a bug for this after this bug's landing.

Comment 5

[Decathlon]

Attachment: patch-v2 for checkin

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 2553a8e486b5