1121432 - Findbar previous and next button look bad in devedition dark theme

Status: RESOLVED WORKSFORME

(DevTools :: General, defect)

Comment 1

[Tim Nguyen :ntim]

Attachment: findbar-arrows.svg

Assets for anyone who'd like to work on this.

Comment 2

[Brian Grinstead [:bgrins]]

This a regression - things look fine in 36.

Comment 3

[Brian Grinstead [:bgrins]]

I'm guessing this is due to Bug 891258

Comment 4

[Tim Nguyen :ntim]

Should be easier to work on once bug 1096413 is resolved.

Comment 5

[Tim Nguyen :ntim]

Attachment: Patch

This also fixes bug 1131765.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8594641 [details] [diff] [review]
Patch

Review of attachment 8594641 [details] [diff] [review]:
-----------------------------------------------------------------

This uses the inverted close icon also for the light theme, which is wrong. Also, the new arrow images are off-center on Win8, at least.

::: browser/themes/shared/devedition.inc.css
@@ +223,5 @@
> +  border-radius: 0;
> +}
> +
> +.browserContainer .findbar-textbox[status="notfound"] {
> +  background-color: #EB5368 !important; /* --theme-highlight-red */

What's with the comment here? :-)

Comment 7

[:Gijs (he/him)]

Attachment: off-center-arrows.PNG

Comment 8

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #7)
> Created attachment 8594697 [details]
> off-center-arrows.PNG

Not sure why that happens on Windows 8, since I haven't changed the padding at all.

Comment 9

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #8)
> (In reply to :Gijs Kruitbosch from comment #7)
> > Created attachment 8594697 [details]
> > off-center-arrows.PNG
> 
> Not sure why that happens on Windows 8, since I haven't changed the padding
> at all.

Are you sure the image size hasn't changed at all?

Comment 10

[Tim Nguyen :ntim]

Probably irrelevant at this point, even for the light/dark themes.