1121550 - One-off button list header half visible when there's no one-off engine to display in the search panel

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Florian Quèze [:florian]]

Attachment: Screenshot

In bug 1109854 we changed a xul:hbox to a xul:deck. Now, because of bug 589569, the deck is half visible even when collapsed. See attached screenshot. Looking at this through DOM Inspector shows that the height of the collapsed deck is 7px, that is, the border top (1px) + padding top (3px) + padding bottom (3px).

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Using hidden instead of collapsed works around this.

I would prefer if bug 589569 could be fixed, but we may have to go with a workaround.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8548993 [details] [diff] [review]
Patch

Review of attachment 8548993 [details] [diff] [review]:
-----------------------------------------------------------------

just mention bug 589569 in a comment

Comment 3

[Marco Mucci [:MarcoM]]

Hi Florian, can you provide a point value.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/a46d323baa06

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a46d323baa06

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8548993 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1109854
[User impact if declined]: the last search suggestion may be cut, see attachment 8548991 [details], when all one-off engines are hidden.
[Describe test coverage new/current, TBPL]: on m-c, will be verified by QA
[Risks and why]: very low, one line fix.
[String/UUID change made/needed]: none.

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Verified that the last suggestion is not cut when all the one-click search engines are hidden using Nightly 38.0a1 2014-01-18 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8548993 [details] [diff] [review]
Patch

Aurora+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1b5f44480b65

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Developer Edition 37.0a2 2014-01-21 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.