1121746 - Use RequireJS to modularize fxpay and improve tests

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P5)

Description

[Kumar McMillan [:kumar]]

If we add RequireJS to the fxpay JS lib we'll unlock the following possibilities:

- other apps (like Fireplace) can use un-minified fxpay source which will be great for development
- the fxpay test suite can use some really nice isolation patterns. See https://achudnovskij.wordpress.com/2014/09/09/require-js-mock-injection-review-options-and-rfactory-plugin-introduction/
- the fxpay minification process should be more straight forward
- people can run fxpay from the source repository more easily
- the example app can work with un-minified source

Comment 1

[Kumar McMillan [:kumar]]

digitarald suggests that we may be able to get node + browser support with a UMD pattern:

http://davidbcalhoun.com/2014/what-is-amd-commonjs-and-umd/

and maybe rewire could be used for mock injection: https://www.npmjs.com/package/rewire-webpack See also: https://github.com/jhnns/rewire

Comment 2

[Kumar McMillan [:kumar]]

Stuart got this ^5 https://github.com/mozilla/fxpay/pull/102