1121884 - [Flame][Camera]The minimized calling bar will partially cover the 3 camera setting icons at top of view finder.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[SandKing]

Attachment: Bug video: 1511.MP4

[1.Description]:
[Flame][v2.1&v2.2][Camera]After you enter camera from lockscreen with a call processing in background, the calling bar will partially cover the 3 camera setting icons at top of view finder.
See log:"logcat_1511.txt"
Bug video:"1511.MP4"
Found Time:15:11

[2.Testing Steps]: 
1. Launch Phone, and create a conversation.
2. Press "Home" button.
3. Press "Power" key to suspend device.
4. Press "Power" key again.
5. On lockscreen page slide the slider to the left, toward the camera icon.
6. Wait device load to Camera page.



[3.Expected Result]: 
6. The minimized calling bar should be hidden when you launch camera from Lockscreen page

[4.Actual Result]: 
6. The minimized calling bar will partially cover the 3 camera setting icons at top of view finder.

[5.Reproduction build]: 
Flame 2.1:
Gaia-Rev        6957ac8a322234ec99c8abb7cc18dc6a2e0176db
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/6600eba54256
Build-ID        20150114001300
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150114.035135
FW-Date         Wed Jan 14 03:51:46 EST 2015
Bootloader      L1TC000118D0

Flame 2.2
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Build-ID        20150114002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150114.040029
FW-Date         Wed Jan 14 04:00:40 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[SandKing]

Attachment: Bug log: logcat_1511.txt

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: 2015-01-18-18-11-38.png

Functionality okay but need UI improvement.

Comment 3

[Eric Chang [:ericcc] [:echang]]

Nom for 2.2? for bad UI.

Comment 4

[Hema Koka [:hema]]

Blocking Reason: Bad User experience with diminished access to camera functions on HUD

Wilson, please take an initial look and route accordingly. thanks!

Comment 5

[Wilson Page [:wilsonpage]]

IMO there are several options:

A. Call status bar is never shown in fullscreen apps (like Camera and Gallery)
B. App's could use some kind of hook/event to allow them to adapt/reposition UI based on the call status bar.
C. Status bar could be swipable up/down manually by the user to give them the ability to move it when it's obscuring content.

Looping in world renowned :amylee to advise...

Comment 6

[Amy Lee [:amylee] UX]

(In reply to Wilson Page [:wilsonpage] from comment #5)
> IMO there are several options:
> 
> A. Call status bar is never shown in fullscreen apps (like Camera and
> Gallery)
> B. App's could use some kind of hook/event to allow them to adapt/reposition
> UI based on the call status bar.
> C. Status bar could be swipable up/down manually by the user to give them
> the ability to move it when it's obscuring content.
> 
> Looping in world renowned :amylee to advise...

Ha, thanks Wilson. Taking photos while a call is in progress seems to be an edge case. I would opt for either option A or C but I will get Tif to have the final say from UX. NI'ing Tiff.

Comment 7

[Tiffanie Shakespeare [:tif]]

Taking calls during a call is definitely an edge case.

I agree with Amy about either option A or C. A is going probably going to be easier as C would require some further design and discussion to make sure it wouldn't interfere with the notification interaction.

Comment 8

[Wilson Page [:wilsonpage]]

Moving this from 'Camera' to 'System' and NI :gmarty (worked on status bar) to find a better home for this.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Alive, this looks like an attention screen issue. Any idea what's going on?

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

This is a missing part from bug 927862.
The spec of the new attention window said we should always show attention toaster in lockscreen but didn't mention that what should happen if opening the secure camera from lockscreen.

What we could do here is:
Use Service.query('getTopMostWindow') in attention_toaster.js and in addition listen to secure-appopened/secureappclosed to update the toaster state.

Comment 11

[GitHub Autolander Bot]

Attachment: [PullReq] alivedise:bugzilla/1121884/toggle-toaster-on-secure-app to mozilla-b2g:master

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8554460 [details] [review]
[PullReq] alivedise:bugzilla/1121884/toggle-toaster-on-secure-app to mozilla-b2g:master

nice!

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/e46c388920f4d102581efb9365c22b02820b3003

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8554460 [details] [review]
[PullReq] alivedise:bugzilla/1121884/toggle-toaster-on-secure-app to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression exactly; bug 927862 makes this problem easier to note because now attention toaster will timeout and hide itself but before v2.1 the toaster always was there even there was a fullscreen app. The problem is we didn't think of fullscreen app on top of lockscreen case but only considered the toaster on lockscreen should be consistent opened because the user is not able to access utility tray in lockscreen mode.
[User impact] if declined:
User is not able to interact with secure camera (camera launched with passcode enabled on lockscreen)
[Testing completed]: All green
[Risk to taking this patch] (and alternatives if risky):
Riskless because it is just adding one more event(secure app open/close) into the transition state machine.
[String changes made]: NaN

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/1354b3c1d5fdd4cc8f0457701ff14dcfae3ceb04

Comment 16

[Lance（leave from Mozilla）]

Attachment: Verify_video.MP4

Comment 17

[Lance（leave from Mozilla）]

The problem is verified not happen on latest Flame 2.1 & 2.2 & 3.0 build.

Steps:
1. Launch Phone, and create a conversation.
2. Press "Home" button.
3. Press "Power" key to suspend device.
4. Press "Power" key again.
5. On lockscreen page slide the slider to the left, toward the camera icon.
6. Wait device load to Camera page.

  
Actual:
The minimized calling bar will be hidden when you launch camera from Lockscreen page.
Fail rate:0/5
See attachment:Verify_video.MP4

Flame 2.1 version:
Gaia-Rev        9df43e6e696da43b6a1433283dc5b155987747bc
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/095a46f32cd4
Build-ID        20150129003733
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150129.041104
FW-Date         Thu Jan 29 04:11:14 EST 2015
Bootloader      L1TC000118D0

Flame 2.2 version:
Gaia-Rev        6e494f1d2676d231abba7dcc2e2822d1170d2d02
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5e6fac01a72f
Build-ID        20150129003432
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150129.042943
FW-Date         Thu Jan 29 04:29:53 EST 2015
Bootloader      L1TC000118D0

Flame 3.0 version: 
Gaia-Rev 9d2378a9ef092ab1fc15c3a9f7fc4171aab59d57 
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/6bfc0e1c4b29 
Build-ID 20150129010239 
Version 38.0a1 
Device-Name flame 
FW-Release 4.4.2 
FW-Incremental eng.cltbld.20150129.043711 
FW-Date Thu Jan 29 04:37:21 EST 2015 
Bootloader L1TC000118D0

Comment 18

[Shally Li（leave from Mozilla）]

Per Comment 17

Comment 19

[William Hsu [:whsu]]

Hi, Lance,

I saw the reproduction steps you noted on comment 0 is different from the video show (comment 0)
If I follow the reproduction steps of video (comment 0), I still can reproduce this bug.
Could you please file a new bug?
Thanks.

Comment 20

[William Hsu [:whsu]]

(In reply to William Hsu [:whsu] from comment #19)
> Hi, Lance,
> 
> I saw the reproduction steps you noted on comment 0 is different from the
> video show (comment 0)
> If I follow the reproduction steps of video (comment 0), I still can
> reproduce this bug.
> Could you please file a new bug?
> Thanks.

My bad. I NI the wrong person.
I would like to NI "SandKing" since he submitted this bug.

Comment 21

[SandKing]

Hi William,
In the vidoe attached in Comment 0, make a phone call and then tap Camera on Homescreen first, which is to prove that this problem does not exist when you open camera from Home view. This is only for reference. The real bug is like the STR description in Comment 0, or you can refer to Lance verification result in Comment17. And I’ve just verified this issue has already been fixed in lasted Flame 2.1 and Flame2.2.

Flame2.1 bulid:
Gaia-Rev        63f291df9b9ad8498fb8fc7fb8bf070524406a5c
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/70b8982a523d
Build-ID        20150201001213
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.035104
FW-Date         Sun Feb  1 03:51:15 EST 2015
Bootloader      L1TC000118D0

Flame2.2 build:
Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f7414413e3a5
Build-ID        20150201002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.043120
FW-Date         Sun Feb  1 04:31:31 EST 2015
Bootloader      L1TC000118D0

Comment 22

[William Hsu [:whsu]]

(In reply to SandKing from comment #21)
> Hi William,
> In the vidoe attached in Comment 0, make a phone call and then tap Camera on
> Homescreen first, which is to prove that this problem does not exist when
> you open camera from Home view. This is only for reference. The real bug is
> like the STR description in Comment 0, or you can refer to Lance
> verification result in Comment17. And I’ve just verified this issue has
> already been fixed in lasted Flame 2.1 and Flame2.2.
> 

Oh! I see.
Understanding from your demo video (comment 0 - 1511.MP4), the notification bar automatically dismissed after 3 seconds.
It doesn't stay resident on the top of the screen.
Okay. I think it is a acceptable behavior.
No more questions.
Many thanks.