1122095 - [Music] test: Navigation: Verify the user is able to navigating back to previous screen from playing a song

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

See https://moztrap.mozilla.org/manage/case/2376/

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master

Comment 2

[Hubert Figuiere [:hub]]

Comment on attachment 8570506 [details] [review]
[gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master

Rebased to master. Now ready to review. Thanks.

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8570506 [details] [review]
[gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master

Testing the content of the title bar seems like a nice simple proxy for testing that the entire view changed.  Are you confident that it will always happen synchronously when the tap event is delivered? Otherwise I worry that you might have a test that fails intermittently because of timing issues.

The r- is because the moztrap test case you cite uses a playlist view to test the back button and you're testing the songs view.  If you're automating the moztrap test case, then you should at least include a playlist test as well.

It seems like it should be pretty simple to verify that the back button works from the Artists and Albums view as well, and possibly even from their subviews. Can you extend the test to check those things as well?

Comment 4

[David Flanagan [:djf]]

And here's a general question for this and other integration tests: is there a way to tell moztrap that a test is now performed automatically?  Or do we just tell QA about that?

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 8570506 [details] [review]
[gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master

I properly wait for things to be present.

I also test the back button from various other situations.

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8570506 [details] [review]
[gaia] hfiguiere:bug1122095-back-button > mozilla-b2g:master

This looks great!

Comment 7

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/28519

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b1cb8041b7014af9c455d0730c3bde8e14006c6c