Closed
Bug 1122111
Opened 10 years ago
Closed 9 years ago
The way android_tool_prefix is determined for ARM in autoconf/android.m4 is not future-proof
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
ARM
Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla38
People
(Reporter: akiss, Assigned: akiss)
Details
Attachments
(1 file)
1000 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 Build ID: 20141125180439 Steps to reproduce: config.{guess,sub} were updated to 2015-01-01 versions in servo/mozjs (a fork updated now-and-then) and then servo's buildbot tried to configure it /home/servo/.cargo/git/checkouts/mozjs-2284529523a8d467/master/js/src/configure --enable-gczeal --target=arm-linux-androideabi --with-android-ndk=/home/servo/android-ndk-r10c/ --with-android-toolchain=/home/servo/ndk-toolchain/ Actual results: configure failed with the following messages: checking for /home/servo/ndk-toolchain//bin/linux-androideabi-gcc... /home/servo/ndk-toolchain//bin/linux-androideabi-gcc checking for gcc... /home/servo/ndk-toolchain//bin/linux-androideabi-gcc checking whether the C compiler (/home/servo/ndk-toolchain//bin/linux-androideabi-gcc -mandroid -fno-short-enums -fno-exceptions -mandroid -L/home/servo/android-ndk-r10c//platforms/android-5/arch-arm/usr/lib -Wl,-rpath-link=/home/servo/android-ndk-r10c//platforms/android-5/arch-arm/usr/lib --sysroot=/home/servo/android-ndk-r10c//platforms/android-5/arch-arm -llog -Wl,--allow-shlib-undefined ) works... no configure: error: installation or configuration problem: C compiler cannot create executables. It turned out that as configure was running - config.sub rewrote the target "arm-linux-androideabi" specified on command line to "arm-unknown-linux-androideabi", and - configure tried to determine android_tool_prefix by matching the pattern "arm-linux*-android*" against the rewritten target string, - which did not succeed, and thus it took a default branch, which afterwards caused the error. Some digging in the scripts revealed that the code that determines android_tool_prefix is originating from autoconf/android.m4. The pattern at https://mxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#42 cannot cope with the "unknown-" part in the target string. Original discussion: https://github.com/servo/mozjs/pull/23 Expected results: android_tool_prefix="arm-linux-androideabi", which would have happened if the pattern was "arm-*linux*-android*" (one asterisk in front of linux)
Note: Eventhough most of the user story is about a fork, the root cause exists/stems from here.
Updated•10 years ago
|
Component: Untriaged → Build Config & IDE Support
Product: Firefox → Firefox for Android
Attachment #8550210 -
Flags: review?(mh+mozilla)
Updated•9 years ago
|
Attachment #8550210 -
Flags: review?(mh+mozilla) → review+
Attachment #8550210 -
Flags: checkin?(mh+mozilla)
Updated•9 years ago
|
Attachment #8550210 -
Flags: checkin?(mh+mozilla)
Comment 3•9 years ago
|
||
For the sheriff who'd land this: this is trivial enough that a try is unnecessary.
Keywords: checkin-needed
Comment 5•9 years ago
|
||
Thanks!
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fb1945202023
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 38 → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•