Closed
Bug 1122339
Opened 9 years ago
Closed 6 years ago
[Keyboard][Autocorrect] "Ave" and "Rd" aren't in the dictionary (autocorrects to "Ace", "R's"
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: dholbert, Unassigned)
References
Details
STR: 1. Try to type "Ave" or "Rd" into a SMS EXPECTED RESULTS: No autocorrection (because these are common abbreviations used in road names -- e.g. Mozilla's office address, 331 E Evelyn Ave) ACTUAL RESULTS: "Ave" gets autocorrected to "Ace" "Rd" gets autocorrected to "R's" I think these must be missing from the dictionary. It looks like other road abbreviations -- "St" and "Blvd", and "Pkwy" are all in the dictionary (at least, they're listed as suggestions when I type them), so "Ave" & "Rd" should presumably be in there too.
Reporter | ||
Comment 1•9 years ago
|
||
I'm hitting this on a Flame device running an up-to-date FxOS 2.1 nightly build.
Comment 2•9 years ago
|
||
Let's analyze this. It's two different issues: 1. Ave is actually in the dictionary, with a relative low frequency for a 3 letter word (f=20, which is lower than 120.000 other words). Age which we suggest is in the top 110 words in English with f=164. That's why the algorithm autocorrects this. I believe this is a valid correction. 2. Rd is indeed not in the dictionary, R's has f=99, which is quite high (surprising to me tbh), gets normalized to Rs, which is next to the D, so this would be a valid autocorrect too. Bug 879145 would help because Rd could be added to user dictionary. I think we get the word lists from Android or something, maybe Rudy knows if we can add words ourselves or that it'd be overwritten.
Depends on: 879145
Flags: needinfo?(rlu)
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #2) > Let's analyze this. It's two different issues: > > 1. Ave is actually in the dictionary, with a relative low frequency for a 3 > letter word (f=20, which is lower than 120.000 other words). Age which we > suggest is in the top 110 words in English with f=164. That's why the > algorithm autocorrects this. I believe this is a valid correction. To be clear, it's not autocorrecting to "Age" -- it's correcting to "Ace". (Is that word also considered extremely-popular in the algorithm?)
Flags: needinfo?(janjongboom)
Comment 4•9 years ago
|
||
For missing words, I think we could add it, though I think we never did that before. I think the problem would be how we could decide the frequency of that added word?
Flags: needinfo?(rlu)
Reporter | ||
Comment 5•9 years ago
|
||
I could see that being hard to establish, in general -- but in this case (for "Rd"), I'd think you could just copy the frequency of "Blvd" or "Pkwy" and call it good. (Not "St", because that has another meaning -- "Saint" -- which could increase its frequency.)
Reporter | ||
Comment 6•9 years ago
|
||
(to be clear: by "Not St", I meant "I wouldn't suggest copying the frequency of St")
Comment 7•9 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #3) > (In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #2) > > Let's analyze this. It's two different issues: > > > > 1. Ave is actually in the dictionary, with a relative low frequency for a 3 > > letter word (f=20, which is lower than 120.000 other words). Age which we > > suggest is in the top 110 words in English with f=164. That's why the > > algorithm autocorrects this. I believe this is a valid correction. > > To be clear, it's not autocorrecting to "Age" -- it's correcting to "Ace". > (Is that word also considered extremely-popular in the algorithm?) On master it's corrected to Age due to tweaking the algorithm to take vertical aligned keys more seriously. Ace has f=104, also 5x as high as ave.
Flags: needinfo?(janjongboom)
Comment 8•6 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•