Closed Bug 1122451 Opened 9 years ago Closed 9 years ago

Enable test_lockscreen_unlock_to_camera_with_passcode.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: edchen, Assigned: Bebe)

Details

Attachments

(2 files, 2 obsolete files)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27633
46 bytes, text/x-github-pull-request
jlorenzo
: review+
Details | Review
Gaia PR 2.2
46 bytes, text/x-github-pull-request
Bebe
: review+
Details | Review 
Due to Bug 1078270 was fixed, so enable this test script.
Attached file PR 27457 (obsolete) — 

        Attachment #8550214 -
        Flags: review?(florin.strugariu)

    
    

    
  
Comment on attachment 8550214 [details] [review]
PR 27457

I can't find your branch to test the code.

Have you deleted it or something ?

        Attachment #8550214 -
        Flags: review?(florin.strugariu) → review-

    
    

    
  
Comment on attachment 8550214 [details] [review]
PR 27457

The test passes BTW so LGTM

    
    

    
  


  

        Attachment #8551575 -
        Flags: review?(florin.strugariu)

    
    

    
  
Comment on attachment 8551575 [details]
Due to Bug 1078270 was fixed, so enable this test script.

PR - 27509

    
    

    
  
Comment on attachment 8551575 [details]
Due to Bug 1078270 was fixed, so enable this test script.

PR - 27509

    
    

    
  
Hi Bebe,

I push PR again, please review again it.

Thanks,
Edward

    
    

    
  
this still has issues  Edward  :(( 

edwardchen40 wants to merge 197 commits into mozilla-b2g:v2.2 from edwardchen40:bug1122451
Flags: needinfo?(edchen)

    
    

    
  
To fix this issue, you need to create first a pull request from edwardchen40:bug1122451 to mozilla-b2g:master. Please make sure your branch has been created from a recent master.

    
    

    
  
@Johan, 
Sure, it created from a master.
Flags: needinfo?(edchen)

    
    

    
  
Okay. In that case, the current problem is: The pull resquest is ready to be merged on 2.2 directly. That's the reason why it says you want to merge 197 commits.  You need to change the branch of your PR to mozilla-b2g:master.

Otherwise, we can't accept the PR in the current state.
Flags: needinfo?(edchen)

    
    

    
  


  
Updated this patch with  Edward's commit
jlorenzo can you take a look and review this

        Attachment #8553740 -
        Flags: review?(jlorenzo)

    
    

    
  
Comment on attachment 8553740 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27633

Looks good to me. test_lockscreen_unlock_to_camera_with_passcode.py is running properly locally.

        Attachment #8553740 -
        Flags: review?(jlorenzo) → review+

    
    

    
  
Merged in master at https://github.com/mozilla-b2g/gaia/commit/d2d79194fd815b693b22dafedeb60a924ce19dd7.
Status: NEW → RESOLVED
Closed: 9 years ago

          status-b2g-v2.2:
          --- → affected

          status-b2g-master:
          --- → fixed
Resolution: --- → FIXED

        Attachment #8550214 -
        Attachment is obsolete: true
Flags: needinfo?(edchen)

        Attachment #8551575 -
        Attachment is obsolete: true

        Attachment #8551575 -
        Flags: review?(florin.strugariu)

    
    

    
  
Hi Johan,

Please help to merge to v2.2 as well.

Thanks,
Edward
Flags: needinfo?(jlorenzo)

    
    

    
  

      
      
      
      

        Attached file
          
        Gaia PR 2.2
        — 
      

    


  
Flags: needinfo?(jlorenzo)

        Attachment #8554483 -
        Flags: review?(florin.strugariu)
Assignee: nobody → florin.strugariu
QA Whiteboard: [fxosqa-auto-s8][fxosqa-auto-points=1]

    
  

        Attachment #8554483 -
        Flags: review?(florin.strugariu) → review+

    
    

    
  
Merge when tree reopens
Flags: needinfo?(florin.strugariu)

    
    

    
  
Please don't forget to set the status flags when doing branch uplifts.

          status-b2g-v2.2:
          affected → fixed
Target Milestone: --- → 2.2 S4 (23jan)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: