Closed
Bug 1122563
Opened 9 years ago
Closed 9 years ago
UITour-lib.js should be `require()`-able
Categories
(Firefox :: Tours, defect)
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: glind, Assigned: Dexter)
References
Details
Attachments
(1 file)
728 bytes,
patch
|
glind
:
review+
Unfocused
:
review+
|
Details | Diff | Splinter Review |
add this line to the end of it :) ``` // added to make this requireable. if (typeof module !== undefined) module.exports = Mozilla.UITour; ``` Maybe part of the other tour patches, this is trivial.
Assignee | ||
Comment 1•9 years ago
|
||
Does this help?
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8551409 [details] [diff] [review] bug1122563.patch Looks fine to me! I don't believe it causes any side effects.
Attachment #8551409 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8551409 -
Flags: review?(MattN+bmo)
Comment 3•9 years ago
|
||
Comment on attachment 8551409 [details] [diff] [review] bug1122563.patch Review of attachment 8551409 [details] [diff] [review]: ----------------------------------------------------------------- I don't really know anything about that module system but I think Unfocused might. Alessio, are you familiar with it enough to know that this works? If so, I'm fine with it.
Attachment #8551409 -
Flags: review?(MattN+bmo) → review?(bmcbride)
Comment 4•9 years ago
|
||
Comment on attachment 8551409 [details] [diff] [review] bug1122563.patch Review of attachment 8551409 [details] [diff] [review]: ----------------------------------------------------------------- Yep.
Attachment #8551409 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks :Unfocused for the review! I know that is require-able from NodeJS, not familiar enough with RequireJS to give an opinion about that. Do I need to push to try this or can simply flag it as checkin-needed?
Flags: needinfo?(MattN+bmo)
Comment 6•9 years ago
|
||
Don't think this needs a Try run.
Flags: needinfo?(MattN+bmo)
Keywords: checkin-needed
Assignee | ||
Comment 7•9 years ago
|
||
Thanks for flagging it as checkin-needed!
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df5c6946b587
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•