1122628 - The various icons next to filenames are not obvious what they correspond to

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P4)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot of bug

See attached screenshot.

In this screenshot, there are circles with a hole in them. Circles that are filled in green. Circles that are all red with a hole in them. Circles that have some yellow with some green. Circles that have some red with some yellow.

After inspecting the markup I figured out that these corresponded to the types of changes.

All green circle filled in = new file
All green with a hole = preexisting file with only lines added
Yellow means that lines were changed
Red means that lines were removed

With that being said, we should add tooltips to these that say things like "New file", "16 new lines added", "10 lines changed, 3 lines removed", "File removed"

Comment 1

[Mark Côté [:mcote]]

Good points; this should be filed in core.

Comment 2

[Mark Côté [:mcote]]

I've filed this upstream as https://code.google.com/p/reviewboard/issues/detail?id=3812.  I'll keep this bug open until it is fixed (MozReview devs themselves may fix it sometime, but it would be as an upstream patch).

By the way, the Review Board user guide describes the icons at https://www.reviewboard.org/docs/manual/2.0/users/reviews/reviewing-diffs/#the-file-index.

Comment 3

[Mark Côté [:mcote]]

We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.

Comment 4

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.