1122702 - JavaScript Error: "invalid value for aNodeOrItemId" from PlacesUIUtils.jsm

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Philip Chee]

Regression from Bug 1084203[1]
Bug 1084203 ported Bug 1068671[2] but not the regression fix from Bug 1095069[3]

[1] Fix totally empty bookmark manager.
[2] folderReadOnly doesn't pertain to bookmarks or results
[3] Cannot copy or delete bookmarks from search results in library

Comment 1

[Philip Chee]

Attachment: Patch v1.0 copy and paste Bug 1095069

While testing your patch from Bug 1121678 I got a lot of error console spew:

> Sat Jan 17 2015 01:08:59
> Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "invalid value for aNodeOrItemId" {file: "resource://gre/modules/PlacesUIUtils.jsm" line: 835}]'[JavaScript Error: "invalid value for aNodeOrItemId" {file: "resource://gre/modules/PlacesUIUtils.jsm" line: 835}]' when calling method: [nsIController::isCommandEnabled]
> Source file: chrome://communicator/content/places/controller.js
> Line: 1554
>  ----------
> Sat Jan 17 2015 01:08:59
> Error: Error: invalid value for aNodeOrItemId
> Source file: resource://gre/modules/PlacesUIUtils.jsm
> Line: 835
>  ----------
> Sat Jan 17 2015 01:08:59
> Error: An error occurred updating the cmd_delete command: [Exception... "[JavaScript Error: "invalid value for aNodeOrItemId" {file: "resource://gre/modules/PlacesUIUtils.jsm" line: 835}]'[JavaScript Error: "invalid value for aNodeOrItemId" {file: "resource://gre/modules/PlacesUIUtils.jsm" line: 835}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 78"  data: yes]
> Source file: chrome://global/content/globalOverlay.js
> Line: 83
>  ----------
> Sat Jan 17 2015 01:08:59
> Error: An error occurred updating the cmd_cut command: [Exception... "[JavaScript Error: "invalid value for aNodeOrItemId" {file: "resource://gre/modules/PlacesUIUtils.jsm" line: 835}]'[JavaScript Error: "invalid value for aNodeOrItemId" {file: "resource://gre/modules/PlacesUIUtils.jsm" line: 835}]' when calling method: [nsIController::isCommandEnabled]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 78"  data: yes]
> Source file: chrome://global/content/globalOverlay.js
> Line: 83

Comment 2

[Philip Chee]

Comment on attachment 8550475 [details] [diff] [review]
Patch v1.0 copy and paste Bug 1095069

[Approval Request Comment]
Regression caused by (bug #): Bug 1084203
User impact if declined: Users cannot copy or delete bookmarks from search results in library
Testing completed (on m-c, etc.): Firefox equivalent Bug 1095069 landed on Firefox 36 (so we need to land this on 2.33 and 2.34) 
Risk to taking this patch (and alternatives if risky): none bustage fix.
String changes made by this patch: None,

Comment 3

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/d86c8591cd92

Comment 4

[Ian Neal]

Comment on attachment 8550475 [details] [diff] [review]
Patch v1.0 copy and paste Bug 1095069

a=me

Comment 5

[Philip Chee]

Pushed to branches:
http://hg.mozilla.org/releases/comm-aurora/rev/ce25f6b1662d
http://hg.mozilla.org/releases/comm-beta/rev/0ae204c89a72