1122774 - Turn on treeherder staging integration for in tree gecko integration...

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Comment 1

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: bz://1122774/lightsofapollo

Comment 2

[James Lal [:lightsofapollo]]

/r/2633 - Bug 1122774 - Add treeherder integration r=garndt

Pull down this commit:

hg pull review -r f199796f8ee9c2130a3d166ac68bcc9f0aafe5df

Comment 3

[Greg Arndt [:garndt]]

https://reviewboard.mozilla.org/r/2633/#review1819

::: testing/taskcluster/mach_commands.py
(Diff revision 1)
> +                    if 'treeherder' not in test_task['task']['extra']:

Is there a scenario where treeherder wouldn't be defined in a test task's extra info?  It's assumed to be defined in the build task above, but isn't necessary for a test task and we default to an empty dict.

Also, if treeherder is not defined in the task's 'extra', there might not be an extra at all and this would fail with a key error I think.

::: testing/taskcluster/tasks/decision/branch.yml
(Diff revision 1)
> -          GECKO_HEAD_REPOSITORY: '{{repository_url}}'
> +          GECKO_HEAD_REPOSITORY: '{{url}}'

Looks like we'll need to update the mach command for decision graph to pass in the right name.

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8550593 [details]
MozReview Request: bz://1122774/lightsofapollo

r+ with a couple of comments in the review

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aaec6c627ea3

Comment 7

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: Bug 1122774 - Add treeherder integration r=garndt

Comment 8

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...