1122990 - Mark nsPropertiesParser as stack class, and make its mProps member a strong ref; r=froydnj

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Mark nsPropertiesParser as stack class, and make its mProps member a strong ref

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8550796 [details] [diff] [review]
Mark nsPropertiesParser as stack class, and make its mProps member a strong ref

Review of attachment 8550796 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsPersistentProperties.cpp
@@ +176,5 @@
>                                  // escaped whitespaces
>    EParserState mState;
>    // if we see a '\' then we enter this special state
>    EParserSpecial mSpecialState;
> +  nsCOMPtr<nsIPersistentProperties> mProps;

I dunno, in some ways it would be better to reorganize the code so that we didn't have to take a reference here, but meh.

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d6161c63e250