1123140 - Minor ScriptedDirectProxy cleanup

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Tom S [:evilpie]]

Attachment: cleanup

Comment 1

[Eric Faust [:efaust]]

Comment on attachment 8550987 [details] [diff] [review]
cleanup

Review of attachment 8550987 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

::: js/src/proxy/ScriptedDirectProxyHandler.cpp
@@ +684,5 @@
>      // Here we add a bunch of extra sanity checks. It is unclear if they will also appear in
>      // the spec. See step 10-11
>      return ArrayToIdVector(cx, proxy, target, trapResult, props,
>                             JSITER_OWNONLY | JSITER_HIDDEN | JSITER_SYMBOLS,
> +                           cx->names().ownKeys);

OOPS! Nice.

@@ +785,5 @@
>          return false;
>  
>      // step 10
>      if (trapResult.isPrimitive()) {
> +        ReportInvalidTrapResult(cx, proxy, cx->names().enumerate);

Surprised there aren't more of these around.

@@ +1019,5 @@
>      }
>  
>      // step 3
>      RootedObject target(cx, proxy->as<ProxyObject>().target());
> +    MOZ_ASSERT(target->isCallable());

Better than a comment, to be sure.

Comment 2

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fe6eb98ef8c

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9fe6eb98ef8c