Closed
Bug 1123580
Opened 9 years ago
Closed 9 years ago
[Telephony] Reorganize mmi parsing related code
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S4 (23jan)
People
(Reporter: aknow, Assigned: aknow)
Details
Attachments
(1 file, 1 obsolete file)
17.88 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
Just want to reorganize the code to make it clearer.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8551664 -
Flags: review?(htsai)
Comment 2•9 years ago
|
||
Comment on attachment 8551664 [details] [diff] [review] Reorganize mmi parsing related code Review of attachment 8551664 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8551664 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 3•9 years ago
|
||
There is a flaw in previous version. gMMIParser refers to isEmergencyNumber() which is still under TelephonyService. I am thinking about doing it more by extracting them into DialNumberUtils.jsm which provides abilities to check and parse the dial number.
Attachment #8552297 -
Flags: review?(htsai)
Assignee | ||
Updated•9 years ago
|
Attachment #8551664 -
Attachment is obsolete: true
Comment 4•9 years ago
|
||
Comment on attachment 8552297 [details] [diff] [review] #2 Reorganize mmi parsing related code Review of attachment 8552297 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=me with comment addressed, thank you. ::: dom/telephony/gonk/DialNumberUtils.jsm @@ +7,5 @@ > +this.EXPORTED_SYMBOLS = ["DialNumberUtils"]; > + > +const {classes: Cc, interfaces: Ci, utils: Cu, results: Cr} = Components; > + > +Cu.import("resource://gre/modules/XPCOMUtils.jsm"); This should be safe to remove. ::: dom/telephony/gonk/TelephonyService.js @@ +81,5 @@ > Cu.import("resource://gre/modules/PhoneNumberUtils.jsm", ns); > return ns.PhoneNumberUtils; > }); > > +XPCOMUtils.defineLazyGetter(this, "gDialNumberUtils", function() { With gDialNumberUtils, we don't need [1] anymore. Please help remove it. [1] https://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyService.js?from=TelephonyService.js#13
Attachment #8552297 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 5•9 years ago
|
||
try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=50ef1f3276b9
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/755c92298a53
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/755c92298a53
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S4 (23jan)
You need to log in
before you can comment on or make changes to this bug.
Description
•