Closed Bug 1124150 Opened 9 years ago Closed 9 years ago

Remove dead code & data structure from xml2dict.py, Write documentation regarding dictionary blob and predictions

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S7 (6mar)

People

(Reporter: mnjul, Assigned: mnjul)

Details

(Whiteboard: [p=3])

Attachments

(1 file)

[gaia] mnjul:bug_1124150_xml2dict_predictions_annotation > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
The current Latin dictionary blob generation code [1] has had some dead code / data structure since bug 865484 which is almost 2 years ago. I talked with :djf about them and we agree that those dead codes may be removed to avoid confusion and to maintain consistency with the upcoming patch of bug 1102834.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/latin/dictionaries/xml2dict.py has
Alright I'm on this.

What I'm attempting in this bug is not just removing the dead code -- that can be done within minutes plus testing -- I'll study the codes (both xml2dict.py and predictions.js) and also amend comments where needed.
Assignee: nobody → jlu
Status: NEW → ASSIGNED
Target Milestone: --- → 2.2 S5 (6feb)
Summary: Remove dead code & data structure from xml2dict.py → Remove dead code & data structure from xml2dict.py, Write documentation regarding dictionary blob and predictions
Target Milestone: 2.2 S5 (6feb) → 2.2 S7 (6mar)
Comment on attachment 8564018 [details] [review]
[gaia] mnjul:bug_1124150_xml2dict_predictions_annotation > mozilla-b2g:master

Tim, please check the patch mostly for commentary purposes, thanks.
Attachment #8564018 - Flags: review?(timdream)
Comment on attachment 8564018 [details] [review]
[gaia] mnjul:bug_1124150_xml2dict_predictions_annotation > mozilla-b2g:master

Sorry for the late review!
Attachment #8564018 - Flags: review?(timdream) → review+
Keywords: checkin-needed
Whiteboard: [p=3]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: