11246 - Crash on <tree> with border-collapse style

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Neil Deakin]

The XUL code below causes a crash on both the Mac and Win95 M8 builds and
possibly others.

<?xml version="1.0"?>
<?xml-stylesheet href="xul.css" type="text/css"?>

<window id="zzz" xmlns="http://www.mozilla.org/keymaster/gatekeeper/
there.is.only.xul">

<tree style="border-collapse: collapse;">
    <treehead>
        <treerow>
            <treecell>Col 1</treecell>
        </treerow>
    </treehead>
    <treechildren>
        <treerow>
            <treecell>1</treecell>
        </treerow>
    </treechildren>
</tree>
</window>

Removing the style attribute from the tree tag makes it work fine. Note that I
don't know whether border-collapse is allowed on trees.

I tried an HTML table equivalent of the above code, adjusted it in a number of
different ways, but could not get it to crash. So I'm guessing that this is
isolated to XUL trees.

I was testing the code above from a file I created in the res/samples directory.

Comment 1

[Peter Trudelle]

I don't know if that's valid either, although it shouldn't crash.  reassigning
to hyatt for triage.

Comment 2

[David Hyatt]

It's valid.  It shouldn't crash.

Comment 3

[David Hyatt]

Dup of a bug buster has.  Giving it to him.

Comment 4

[buster]

cc hyatt.  David, I think I have a fix for this.  What is the syntax for loading
a XUL test case like this into apprunner so I can test it?  Thanks!

Comment 5

[David Hyatt]

Don't worry about it.  I saw this crash on tables as well as trees, so if you've
plugged the problem with tables, I'll bet trees are safe.  The guy who reported
the bug can handle verifying it with his test case (or better yet he can attach
it to the bug so you can try it out).

Comment 6

[buster]

this should be fixed.

Comment 7

[Neil Deakin]

Attachment: This is the same test case as an attachment.

Comment 8

[ckritzer (gone)]

Verified fixed on:
1999082412 MacOS85

Also tested (verified fixed) on:
1999082412 WinNT
1999082408 Linux6

Comment 9

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eccb2854bc3e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11246: Align text to viewStart to support RTL layouts.