112473 - Eliminate double allocation in CSSParserImpl::ParseProperty()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Johnny Stenback (:jst)]

In CSSParserImpl::ParseProperty() we do:

  nsString* str = new nsString(aPropValue);

which will allocate the nsString object, *and* allocate storage for the string.
In stead of allcating a nsString we should allocate a nsAutoString which will
make us allocate only once if aPropValue fits in the internal nsAutoString
buffer, which is the case most of the time.

Patch coming up...

Comment 1

[Johnny Stenback (:jst)]

Attachment: Allocate nsAutoString, and speed up NS_NewHTMLReflowCommand a bit...

Comment 2

[Johnny Stenback (:jst)]

Taking bug. Reviews?

Comment 3

[Johnny Stenback (:jst)]

Attachment: More nsAutoString fun...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 59576 [details] [diff] [review]
Allocate nsAutoString, and speed up NS_NewHTMLReflowCommand a bit...

r=dbaron, although I wish we weren't bound to nsIUnicharInputStream

Comment 5

[Johnny Stenback (:jst)]

Yeah, me too...

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 59577 [details] [diff] [review]
More nsAutoString fun...

+  *aInstancePtrResult cmd = new nsHTMLReflowCommand(aTargetFrame, aReflowType,

Does this compile?  I don't think you want |cmd| in there...

Comment 7

[Johnny Stenback (:jst)]

Hmm, yeah, loose the |cmd| :-) My build didn't like that either, but I didn't
see my build had stopped before attaching the patch :-)

Comment 8

[Johnny Stenback (:jst)]

Fix checked in.