1125151 - Marketplace elements creates a circular dependency on fireplace

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect)

Description

[[e-mail]]

Fireplace depends on marketplace-elements, and marketplace-elements depends on marketplace-frontend which is an alias for fireplace.

This creates a circular dependency in bower which break tests when packages in bower.json get version bumps:

bower not-cached git://github.com/jrburke/almond.git#0.2.9
bower resolve git://github.com/jrburke/almond.git#0.2.9
bower not-cached git://github.com/mozilla/marketplace-constants.git#0.4.0
bower resolve git://github.com/mozilla/marketplace-constants.git#0.4.0
bower not-cached git://github.com/mozilla/marketplace-elements.git#0.3.4
bower resolve git://github.com/mozilla/marketplace-elements.git#0.3.4
bower not-cached git://github.com/jquery/jquery.git#2.0.2
bower resolve git://github.com/jquery/jquery.git#2.0.2
bower not-cached git://github.com/hokaccha/js-flipsnap.git#0.3.0
bower resolve git://github.com/hokaccha/js-flipsnap.git#0.3.0
bower not-cached git://github.com/mozilla/marketplace-core-modules.git#1.6.1
bower resolve git://github.com/mozilla/marketplace-core-modules.git#1.6.1
bower not-cached git://github.com/jrburke/requirejs-bower.git#2.1.4
bower resolve git://github.com/jrburke/requirejs-bower.git#2.1.4
bower not-cached git://github.com/WebReflection/document-register-element.git#~0.1.6
bower resolve git://github.com/WebReflection/document-register-element.git#~0.1.6
bower not-cached git://github.com/jashkenas/underscore.git#1.4.4
bower resolve git://github.com/jashkenas/underscore.git#1.4.4
bower not-cached git://github.com/mozilla/fxpay.git#0.0.8
bower resolve git://github.com/mozilla/fxpay.git#0.0.8
bower download https://github.com/jrburke/almond/archive/0.2.9.tar.gz
bower not-cached git://github.com/ngokevin/salvattore.git#1.0.9
bower resolve git://github.com/ngokevin/salvattore.git#1.0.9
bower download https://github.com/hokaccha/js-flipsnap/archive/0.3.0.tar.gz
bower download https://github.com/jquery/jquery/archive/2.0.2.tar.gz
bower download https://github.com/mozilla/marketplace-elements/archive/v0.3.4.tar.gz
bower download https://github.com/mozilla/marketplace-constants/archive/v0.4.0.tar.gz
bower download https://github.com/mozilla/marketplace-core-modules/archive/v1.6.1.tar.gz
bower download https://github.com/jrburke/requirejs-bower/archive/2.1.4.tar.gz
bower download https://github.com/WebReflection/document-register-element/archive/0.1.6.tar.gz
bower download https://github.com/mozilla/fxpay/archive/0.0.8.tar.gz
bower download https://github.com/jashkenas/underscore/archive/1.4.4.tar.gz
bower download https://github.com/ngokevin/salvattore/archive/v1.0.9.tar.gz
bower extract almond#0.2.9 archive.tar.gz
bower extract requirejs#2.1.4 archive.tar.gz
bower extract marketplace-elements#0.3.4 archive.tar.gz
bower extract flipsnap#0.3.0 archive.tar.gz
bower invalid-meta requirejs is missing "ignore" entry in bower.json
bower extract marketplace-core-modules#1.6.1 archive.tar.gz
bower resolved git://github.com/jrburke/requirejs-bower.git#2.1.4
bower extract document-register-element#~0.1.6 archive.tar.gz
bower extract fxpay#0.0.8 archive.tar.gz
bower extract jquery#2.0.2 archive.tar.gz
bower extract underscore#1.4.4 archive.tar.gz
bower extract salvattore-moox#1.0.9 archive.tar.gz
bower extract marketplace-constants#0.4.0 archive.tar.gz
bower invalid-meta flipsnap is missing "main" entry in bower.json
bower invalid-meta flipsnap is missing "ignore" entry in bower.json
bower resolved git://github.com/mozilla/marketplace-elements.git#0.3.4
bower resolved git://github.com/hokaccha/js-flipsnap.git#0.3.0
bower not-cached git://github.com/mozilla/fireplace.git#~7.2
bower resolve git://github.com/mozilla/fireplace.git#~7.2
bower download https://github.com/mozilla/fireplace/archive/v7.2.6.tar.gz
bower resolved git://github.com/ngokevin/salvattore.git#1.0.9
bower resolved git://github.com/WebReflection/document-register-element.git#0.1.6
bower invalid-meta underscore is missing "main" entry in bower.json
bower invalid-meta underscore is missing "ignore" entry in bower.json
bower resolved git://github.com/jashkenas/underscore.git#1.4.4
bower resolved git://github.com/mozilla/fxpay.git#0.0.8
bower invalid-meta marketplace-core-modules is missing "main" entry in bower.json
bower resolved git://github.com/mozilla/marketplace-core-modules.git#1.6.1
bower resolved git://github.com/jrburke/almond.git#0.2.9
bower extract marketplace-frontend#~7.2 archive.tar.gz
bower invalid-meta jquery is missing "ignore" entry in bower.json
bower resolved git://github.com/jquery/jquery.git#2.0.2
bower invalid-meta marketplace-constants is missing "main" entry in bower.json
bower resolved git://github.com/mozilla/marketplace-constants.git#0.4.0
bower invalid-meta marketplace-frontend is missing "main" entry in bower.json
bower resolved git://github.com/mozilla/fireplace.git#7.2.6
bower not-cached git://github.com/mozilla/fxpay.git#0.0.7
bower resolve git://github.com/mozilla/fxpay.git#0.0.7
bower download https://github.com/mozilla/fxpay/archive/0.0.7.tar.gz
bower extract fxpay#0.0.7 archive.tar.gz
bower resolved git://github.com/mozilla/fxpay.git#0.0.7
bower ECONFLICT Unable to find suitable version for fxpay
make: *** [install] Error 1
The command "make install" failed and exited with 2 during .

Comment 1

[Mark Striemer [:mstriemer]]

Fixed by bug 1125145.