1125288 - KidFox: Restricted profiles - Hide all developer tools and related UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1125288-hide-developer-tools-WIP.patch

WIP patch based on changes in bug 1187260.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1125288-developer-tools.patch

Final version for review.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8639866 [details] [diff] [review]
1125288-developer-tools.patch

Review of attachment 8639866 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by r+ :)

::: mobile/android/base/preferences/GeckoPreferences.java
@@ +484,5 @@
> +                if (header.id == R.id.pref_header_language && !localeSwitchingIsEnabled) {
> +                    // If locale switching is disabled, remove the section
> +                    // entirely. This logic will need to be extended when
> +                    // content language selection (Bug 881510) is implemented.
> +                    iterator.remove();

Just to confirm, did you have to change the iterator syntax here to avoid a concurrent modification exception?

Comment 4

[Allison Naaktgeboren :ally]

heh, looks like you don't need me for this one. :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Margaret Leibovic from comment #3)
> Just to confirm, did you have to change the iterator syntax here to avoid a
> concurrent modification exception?

Yeah, previously we jumped out of the loop after modifying the list. Now I want to continue iterating over the modified list.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/06f2c8aca1e37821e6a0827c9540a63239dbfdb9
changeset:  06f2c8aca1e37821e6a0827c9540a63239dbfdb9
user:       Sebastian Kaspari <[e-mail]>
date:       Thu Jul 30 19:48:38 2015 +0200
description:
Bug 1125288 - Restricted profiles: Hide all developer tools and related UI. r=margaret

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06f2c8aca1e3

Comment 8

[u549602]

Verified as fixed on latest Aurora