1125419 - [Text Selection][Browser] The page scrolls down during text selection

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20150123_ScrollWhileTextSelection.txt

Description:
When the user tries to select multiple lines on a webpage, the page scrolls down as the user drags the carat downward. This makes it difficult for user to select multiple lines.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150123093302.
2) Navigate to msn.com on the browser.
3) Select any article.
4) Long-press on a word.
5) Drag down the right carats to select multiple lines.
  
Actual:
The page scrolls down, which makes it difficult to select multiple lines.
  
Expected: 
The page does not scroll during the text selection.

Note:
On an Android device, the same webpage does not scroll down while text selection.
  
Environmental Variables:
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150123002505
Gaia: 237008137f6d72b9cad25ff4faff14ff2c40ac63
Gecko: be24dd482a83
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 10/10
See attached: video clip, logcat
http://youtu.be/wpz246wdLh0

=========================================
This issue also reproduces on Flame 2.2.

Device: Flame 2.2 (319mb, full flash)
Build ID: 20150123002505
Gaia: 237008137f6d72b9cad25ff4faff14ff2c40ac63
Gecko: be24dd482a83
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Text selection is a new feature on Flame 2.2. N/A on v2.1.

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This will cause end user frustration so nominating this 2.2?

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

kats, before LayoutEventRegions enabled, we can skip apz by setting SetMayHaveTouchCaret and then NeedToWaitContent at [1] would check this flag. So that if user drag on touch caret, the page doesn't scroll by apzc. But since LayoutEventRegions enabled by default in bug 928833, SetMayHaveTouchCaret cannot prevent this behavior. Do you have any suggestion for this problem? Thanks.

[1]: https://dxr.mozilla.org/mozilla-central/source/gfx/layers/apz/src/InputQueue.cpp#199

Comment 3

[Kartikaya Gupta (email:[e-mail])]

We should do something like bug 1119355 where we add a dummy touch listener to the content element for the caret. That way it will get added to the dispatch-to-content region in the event regions, and the preventDefault behaviour will work.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add dummy touch event listener to touch/selection carets to prevent apz scroll when dragging touch/selection carets.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8555138 [details] [diff] [review]
Add dummy touch event listener to touch/selection carets to prevent apz scroll when dragging touch/selection carets.

Review of attachment 8555138 [details] [diff] [review]:
-----------------------------------------------------------------

You don't remove these listeners anywhere, but you'll definitely need to!

Comment 6

[howie [:howie]]

Triage: blocker

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add dummy touch event listener to touch/selection carets to prevent apz scroll when dragging touch/selection carets v2.

Move addEventListener to nsCanvasFrame so that we can removeEventListener on nsCanvasFrame::DestroyFrom().

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba68e6ca9a50

Comment 9

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add dummy touch event listener to touch/selection carets to prevent apz scroll when dragging touch/selection carets v3. (carry r+: roc)

Fix try error.

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

latest try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=31d86f4410c6

Comment 11

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Disable touch/selection caret before testing test_bug648573.html.

Fix try fail.

Comment 12

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Disable touch/selection caret before testing test_bug648573.html v2.

Upload missing file.

Comment 13

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add dummy touch event listener to touch/selection carets to prevent apz scroll when dragging touch/selection carets v4. (carry r+: roc)

rebased.

Comment 14

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

latest try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=914c60a96f36

Comment 15

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8557728 [details] [diff] [review]
Add dummy touch event listener to touch/selection carets to prevent apz scroll when dragging touch/selection carets v4. (carry r+: roc)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: User would hard to drag carets.
Testing completed: Try is positive on master try.
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: not available

Comment 16

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8557716 [details] [diff] [review]
Disable touch/selection caret before testing test_bug648573.html v2.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: User would hard to drag carets.
Testing completed: Try is positive on master try.
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: not available

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1bc43872656
https://hg.mozilla.org/integration/mozilla-inbound/rev/215aa5f16853

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1bc43872656
https://hg.mozilla.org/mozilla-central/rev/215aa5f16853

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/fbf0ce1d0801
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/07ada5f0f9ca

Comment 20

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: The webpage does not scroll while the user moves the carats.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150220010206
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150220002501
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: b864abe1c6b3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 21

[ssba5206]

Hello guys,

I have a similar issue in (the latest) FireFox for Android (both FF and FF beta): when I select some text in a textarea and move the cursor more to the right than the end-of-line for the line where the selection was started, the whole text gets selected (and the screen is scrolled to the bottom).

Should I file a separate bug, or it's better to reopen this one?

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Please file a separate bug, thanks!