Closed Bug 1125526 Opened 9 years ago Closed 9 years ago

Intermittent browser_webconsole_assert.js | only six messages are displayed, no output from the true assert - Got 5, expected 6

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox36 unaffected, firefox37 fixed, firefox38 fixed, firefox-esr31 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 38
Tracking Flags:
Tracking Status
firefox36 --- unaffected
firefox37 --- fixed
firefox38 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: philor, Assigned: sjakthol)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

webconsole-assert-failure.patch
1.11 KB, patch
past
: review+
Details | Diff | Splinter Review 
      No description provided.
Console messages when everything works
> 09:38:07.650 test()
> 09:38:07.667 undefined
> 09:38:07.668 "start"1 test-console-assert.html:12:8
> 09:38:07.668 "false assert"1 test-console-assert.html:13:8
> 09:38:07.669 "falsy assert"1 test-console-assert.html:14:8
> 09:38:07.669 "end"1 test-console-assert.html:16:8
> TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_assert.js | only six messages are displayed, no output from the true assert

Console messages when failure occurs:
> 09:38:12.270 test()
> 09:38:12.285 "start"1 test-console-assert.html:12:8
> 09:38:12.286 "false assert"1 test-console-assert.html:13:8
> 09:38:12.287 "falsy assert"1 test-console-assert.html:14:8
> 09:38:12.288 "end"1 test-console-assert.html:16:8
> TEST-UNEXPECTED-FAIL | browser/devtools/webconsole/test/browser_webconsole_assert.js | only six messages are displayed, no output from the true assert - Got 5, expected 6

Thus it appears that the output "undefined" from executing "test()" in the console is not always printed before the messages are logged to the console.

This patch makes the test wait for the output from test() before asserting on the number of messages.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02459324bd88
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8564489 - Flags: review?(past)
Comment on attachment 8564489 [details] [diff] [review]
webconsole-assert-failure.patch

Review of attachment 8564489 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8564489 - Flags: review?(past) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/e1d276c611ea
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e1d276c611ea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
In addition to their inputs declared in moz.build files, generated files
may also depend on other files, such as #includes in preprocessed files.
Let's provide a place for file_generate.py to write out those extra
dependencies.
Attachment #8676906 - Flags: review?(mh+mozilla)
Attachment #8676906 - Attachment is obsolete: true
Attachment #8676906 - Flags: review?(mh+mozilla)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: