Closed
Bug 1126337
Opened 9 years ago
Closed 9 years ago
[Loop] Play ended tone when leaving a Room from Firefox Hello application for every user that leaves a Room
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jaoo, Assigned: jaoo)
Details
(Whiteboard: [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1])
Attachments
(1 file)
This is follow-up or regression (whatever) of bug 1124707. We play the 'connected' tone instead the 'ended' one. This was a nice mistake.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → josea.olivera
Whiteboard: [Room1.1.1_TestRun2]
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8555304 -
Flags: review?(borja.bugzilla)
Updated•9 years ago
|
Attachment #8555304 -
Flags: review?(borja.bugzilla) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Landed on master branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/fc9b8ce67d0395910b0ff993346a41597faaabf5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]
Comment 3•9 years ago
|
||
Very simple patch, no risky. Jose Antonio, could you be so kind of uplifting it to 1.1.1 branch? Thanks a lot!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]
Assignee | ||
Comment 4•9 years ago
|
||
Landed on 1.1.1 branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c9da92a3cef552ff9252269b74ae2bd22f704cec Maria, could you please update the whiteboard if needed please? Thanks!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][loop approved for 1.1.1][In loop 1.1.1]
Comment 5•9 years ago
|
||
It's pefect! thanks a lot!
Updated•9 years ago
|
Whiteboard: [Room1.1.1_TestRun2][loop approved for 1.1.1][In loop 1.1.1] → [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1]
Comment 6•9 years ago
|
||
Tested and now when an invited/owner user leaves the room, a sound is listened. Fire E 2.0 Loop 1.1.1/39a5284
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•