1126420 - fatal (debug-build) assertion with width:-moz-max-content in vertical writing mode

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase -- fatally asserts in debug build

The patch for bug 1122366 means that in vertical writing mode, nsBlockFrame::IsSelfEmpty will be passing width coords (instead of height) to IsNonAutoNonZeroHeight(), and these may include things like -moz-max-content that it is not prepared to handle.

This is similar to the assertion we had in bug 1113216, and I propose to wallpaper it in the same way for now, treating enumerated values for block-size as if they were 'auto' for the purposes of this check.

IsNonAutoNonZeroHeight() is only used by nsBlockFrame::IsSelfEmpty, so the worst that will happen as a result of this is that we'll sometimes incorrectly consider a block to be empty (e.g. if it has width:-moz-available), and we might therefore collapse margins in a case where we shouldn't.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Don't assert when intrinsic size values are used for a block-size property, just pretend they're 'auto' for now

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8555391 [details] [diff] [review]
Don't assert when intrinsic size values are used for a block-size property, just pretend they're 'auto' for now

r=dbaron.

Maybe add a comment pointing this out in relevant bugs?  (perhaps the ones in the comment?)

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31e36157db00

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/31e36157db00