Closed
Bug 1126499
Opened 9 years ago
Closed 9 years ago
Lollipop build bustage: MP4Stream.h: No such file or directory
Categories
(Core :: Audio/Video, defect)
Tracking
()
People
(Reporter: botond, Assigned: seinlin)
References
Details
Attachments
(2 files)
5.04 KB,
text/plain
|
Details | |
1.36 KB,
patch
|
seinlin
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
STR: 1) Clone the B2G repo. 2) ./config.sh nexus-5-l 3) ./build.sh This results in the following compiler error: In file included from objdir-gecko/dom/media/mediasource/Unified_cpp_media_mediasource0.cpp:2:0: gecko/dom/media/mediasource/ContainerParser.cpp:14:23: fatal error: MP4Stream.h: No such file or directory #include "MP4Stream.h" ^ Full error output attached. The offending include was added in bug 1102642. I'm not sure what's causing the error, as MP4Stream.h is present in the EXPORTS of dom/media/fmp4/moz.build.
Comment 1•9 years ago
|
||
is it located in $MOZ_OBJDIR/dist/include/MP4Stream.h ? did you re-run ./mach build ? (I'm not familiar with b2g build, and it builds fine on all B2G try runs)
Comment 2•9 years ago
|
||
Looks like dom/media/fmp4/moz.build is only processed when MOZ_FMP4 enabled [1], and current configure.in doesn't do that for Lollipop [2]. Unfortunately, MOZ_FMP4=1 trigger another error as below. Blake, could you please help check that? In file included from Unified_cpp_dom_media_fmp4_gonk0.cpp:29:0: ../../../../../../gecko-dev/dom/media/fmp4/gonk/GonkVideoDecoderManager.cpp: In member function 'void mozilla::GonkVideoDecoderManager::codecReserved()': ../../../../../../gecko-dev/dom/media/fmp4/gonk/GonkVideoDecoderManager.cpp:494:42: error: 'class android::GonkNativeWindow' has no member named 'getBufferQueue' surface = new Surface(mNativeWindow->getBufferQueue()); [1] https://dxr.mozilla.org/mozilla-central/source/dom/media/moz.build?from=dom/media/moz.build#42 [2] https://dxr.mozilla.org/mozilla-central/source/configure.in#292
Flags: needinfo?(bwu)
Comment 3•9 years ago
|
||
I can make the entire code conditional on FMP4 being active.
Comment 4•9 years ago
|
||
Currently MOZ_FMP4 is not enabled yet on B2G L. See also bug 1112770.
Flags: needinfo?(bwu)
Comment 5•9 years ago
|
||
It looks MP4Stream.h is not exported in [1] due to [2] as comment 2. [1]https://dxr.mozilla.org/mozilla-central/source/dom/media/fmp4/moz.build#11 [2]https://dxr.mozilla.org/mozilla-central/source/dom/media/moz.build#42 jya, To cut this binding, is it possible to move MP4Stream to gecko/media/libstagefright/ which MP4_Demuxer locates as well?
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 6•9 years ago
|
||
Anthony and Matt, I think we can fix this compile issue as [1]. Could you review this patch? Thanks! [1] https://dxr.mozilla.org/mozilla-central/source/dom/media/eme/MediaKeys.cpp#21
Attachment #8556312 -
Flags: review?(matt.woodrow)
Attachment #8556312 -
Flags: review?(ajones)
Comment 7•9 years ago
|
||
I hadn't seen this one was done already, so I wrapped something and it's exactly my solution. so r+ for me :)
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8556312 [details] [diff] [review] bug-1126499.patch Per comment 7.
Attachment #8556312 -
Flags: review?(matt.woodrow)
Attachment #8556312 -
Flags: review?(ajones)
Attachment #8556312 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/f64e404de9d9
Assignee | ||
Updated•9 years ago
|
blocking-b2g: --- → 2.2?
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8556312 [details] [diff] [review] bug-1126499.patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): compile error User impact if declined: compile failed Testing completed: verify on m/c and try server Risk to taking this patch (and alternatives if risky): low, only add compile flag for mp4 source code. String or UUID changes made by this patch: none
Attachment #8556312 -
Flags: approval-mozilla-b2g37?
Assignee | ||
Comment 11•9 years ago
|
||
try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=461326005628
Updated•9 years ago
|
blocking-b2g: 2.2? → 2.2+
Assignee | ||
Updated•9 years ago
|
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → fixed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f64e404de9d9
Assignee: nobody → kli
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•9 years ago
|
Attachment #8556312 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in
before you can comment on or make changes to this bug.
Description
•