1127207 - [Text Selection] migrate touchcarettap handler to selectionstatechange

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Gecko from bug 1120750 will handle touchcarettap event in selectionstatechange. We also need to modify gaia and add test before bug 1120750 is landing.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

There's still issue after Gecko with bug 1119126 and bug 1120750.

When focused element may blocked by keyboard, gecko help us to auto scroll the element into visible field. In that case, bubble triggered by singletap won't update its position. We need to figured how to fix this issue.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Morris,
could I have your feedback on this patch?
Basically, I've separated collapse and selection mode here.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8557802 [details] [review]
PR to master

Looks good.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8557802 [details] [review]
PR to master

Hi Morris,
I've modified a little bit, so could I have your feedback again before landing.
This gaia might break some use cases with current master
1. when keyboard shows up, the bubble is still there
2. long press empty column will have selectAll button

So, we'd better make sure the two gecko are ready.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8557802 [details] [review]
PR to master

Looks great!! Some comments on github. Thanks

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8557802 [details] [review]
PR to master

Hi Alive,
could I have your review on this patch?
This patch need to be merged before bug 1119126 and bug 1120750 which migrate touchoncaret event into selectionstatechange and send new position event while frame is resized (currently we listen to system-resize as a workaround).

I also separate collpased handler from selection handler.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8557802 [details] [review]
PR to master

r+ with nits

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks, master
https://github.com/mozilla-b2g/gaia/commit/827389929cc20dda5ade6e887d99894905f4f7b9

Comment 9

[GitHub Autolander Bot]

Attachment: [PullReq] cctuan:1127207-v22 to mozilla-b2g:v2.2

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

This gaia patch blocks bug 1119126 and bug 1120750.

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8561176 [details] [review]
[PullReq] cctuan:1127207-v22 to mozilla-b2g:v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a regression nor feature.
[User impact] if declined:
This is gaia patch for bug 1120750 and bug 1119126, without its landing, we cannot solve below issues.
bug 1120750: User impact if declined: The position of shortcut bubble for copy/paste would be wrong when it appears.
bug 1119126:
Copy/paste bubble position may be wrong after scroll or reflow.

[Testing completed]: Yes, manual test and unit test.
[Risk to taking this patch] (and alternatives if risky):
No. However this gaia patch might break some marionette test before bug 1120750 and bug 1119126 are merged.
[String changes made]:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this when you get a chance.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks for reminding, I already write it in comment 11.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/1be79d05b8b34e9ccfa3a870da81f30c7ecbc4ec