Closed Bug 1127307 Opened 9 years ago Closed 9 years ago

Always use inheritance rather than composition for PLDHashTable entries

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 38.0

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Patch v1.0 fixit
8.40 KB, patch
rkent
: review+
Details | Diff | Splinter Review 
(From Bug 1124973 comment #7)
> Side note: we ought to switch from composition to inheritance so that we can
> use static_cast instead of reinterpret_cast in a couple of spots. See the
> patches on the original bug.
Attached patch Patch v1.0 fixit — — Splinter Review 
Followup to Bug 1126859
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8559364 - Flags: review?(kent)
Comment on attachment 8559364 [details] [diff] [review]
Patch v1.0 fixit

Review of attachment 8559364 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!
Attachment #8559364 - Flags: review?(rkent) → review+
https://hg.mozilla.org/comm-central/rev/42903800f739
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: