Closed Bug 1127547 Opened 9 years ago Closed 9 years ago

Follow-up fixes for custom context menu

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Pull request
47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review 
We found that we could detect and disable the built-in context menu specifically. Doing so avoids the race between our JS and the other gesture recognizers since we don't need to worry about ordering.
Attached file Pull request — 
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED

        Attachment #8556717 -
        Flags: review?(sarentz)

    
    

    
  
Comment on attachment 8556717 [details] [review]
Pull request

With regard to namespacing .. can we do a similar thing as in https://github.com/mozilla/firefox-ios/pull/116/files#diff-2 ? I am also going to follow that pattern for the ReaderMode.js code.

I think that is the only thing that really needs a fix. Otherwise, let's merge this and see how this works in practice. (I see you already found one case where it fails in iframes.)

        Attachment #8556717 -
        Flags: review?(sarentz) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: