112771 - hitting single-letter shortcuts should change focus from folder pane to thread pane

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 70097 [and bug 112477].

if focus is in the folder pane, hitting a single-letter shortcut should switch
focus to the thread pane.

examples:
1. click on a folder in the folder pane, or tab over to the folder pane and
select a folder with the up/down arrows. focus will be in the folder pane, of
course.
2. hit 'f' to display the first read/unread message in the thread pane. or, hit
'n' to display the first unread message in the thread pane.

actual results: the single-letter shortcut will display the message, but it will
*not* switch focus to the thread pane. focus currently remains in the folder
pane. you have to hit the Tab key to actually change focus [an extra step to
remember].

Comment 1

[scottputterman]

reassigning to ssu.

Comment 2

[Jesse Ruderman]

Dup of bug 92693?  Bug bug is 'Hitting "next message" doesn't change selection 
focus to msg pane'.

Comment 3

[scottputterman]

I think they are related but not a dup.

Comment 4

[Olga]

Scott, would you please expand your comment #3?
It seems the same case with intentionally selected folder.

Comment 5

[Sean Su]

Attachment: patch to fix focus issue.

I've tested this with the standalone message window, and it does works fine. 
It does not set the focus back to mail&news window.

Comment 6

[varada]

Comment on attachment 61174 [details] [diff] [review]
patch to fix focus issue.

r=varada
looks good to me.

Comment 7

[Sean Su]

what I meant to say about the standalone message window is that it does not
break its functionality.

Comment 8

[(not reading, please use [e-mail] instead)]

it works from the stand alone msg window, but do you get any js errors /
warnings about SetFocusThreadPane() not being found to the console?

I'd think so, because it's defined in mail3PaneWindowCommands.js, which we
shouldn't be including into the stand alone msg window.  if we are, that's bad.

can you double check what's going on?

One question is, where should focus go in the std alone msg window after "n"?
I'd say into the message, so that space (for scroll down) works.  can you see if
it does that?  If not, maybe we can do this:

1) fix your patch to call SetFocusAfterGoNextMessage()
2) in mail3PaneWindowCommands.js. define SetFocusAfterGoNextMessage() to call
SetFocusThreadPane().  in messageWindow.js, define SetFocusAfterGoNextMessage()
to move focus to the right place (the message body).

Comment 9

[Sean Su]

There are no error messages in the console when using the single letter shortcut
keys to advance to the next message.  It turns out that the standalone message
window does not call GoNextMessage().  It calls performNavigation() in
messageWindow.js.  

The focus in the standalone message window does go to the message pane after
using the single letter shortcut keys.

Comment 10

[Sean Su]

adding seth to the cc: list.

Comment 11

[Sean Su]

Attachment: patch containing seth's recommendations

I didn't modify messageWindow.js because it is not affected, but I did create a
new function, SetFocusAfterGoNextMessage().

Comment 12

[Sean Su]

Comment on attachment 64179 [details] [diff] [review]
patch containing seth's recommendations

this bug will be fixed by the patch in bug 70097.

Comment 13

[Sean Su]

patch for bug 70097 got checked in.  marking this fixed.

Comment 14

[Olga]

Verified on Win2K, Linux, Mac OSX - trunk build 01-29-2002.