1127743 - Rocketbar's FTU message is selectable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Shing Lyu [:shinglyu]]

Attachment: screenshot

Description

The FTU message for rocketbar is selectable.

Steps to Reproduce

* Reset or flash the phone to reset it back to factory settings.
* Click through the FTU.
* Click the "Search or enter address" to bring up the FTU.
* A floating box will show up to introduce the rocketbar (see the attachment).
* Long press the text in the floating box.

Expected Results

The text in the box should not be selectable.

Actual Results

The text is selected.

Other Notes


Reproduction Frequency: 

100%

Comment 1

[Candice Serran (:cserran)]

This text selection bug is owned by sys-platorm

Comment 2

[howie [:howie]]

Hi Candice, I'm tracking copy paste gecko work and Gaia apps that are owned by sys-platform (settings, lockscreen, keyboard...etc). But there is per Gaia app work/bug that needs every team's help.

I'd say this one should block, can you help to find someone for this? Thank you.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] mancas:bug1127743 to mozilla-b2g:v2.2

Comment 4

[Manuel Casas Barrado [:mancas]]

Hi Candice who is the best person to review this patch? It prevents the user from select any text in the search page. Also the patch fixes this bug1124575

Comment 5

[Dale Harvey (:daleharvey)]

Hey Manuel

You can give the view to me or Ben Francis

Cheers

Comment 6

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8560381 [details] [review]
[PullReq] mancas:bug1127743 to mozilla-b2g:v2.2

Thanks Dale!

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8560381 [details] [review]
[PullReq] mancas:bug1127743 to mozilla-b2g:v2.2

Retriggered the single failing tests, assume it is unrelated. 

The patch should be done against master and then uplifted, so if you land, please do it against master

Cheers

Comment 9

[Dale Harvey (:daleharvey)]

Try is green, merged to master in https://github.com/mozilla-b2g/gaia/commit/09349e1038ceb73a02ff2824da652cec48460c3d

Comment 11

[bhavana bajaj [:bajaj]]

(In reply to Dale Harvey (:daleharvey) from comment #9)
> Try is green, merged to master in
> https://github.com/mozilla-b2g/gaia/commit/
> 09349e1038ceb73a02ff2824da652cec48460c3d

Dale, can you please request 2.2 approval on this if this is ready to land? Thanks!

Comment 12

[Hermes Cheng (inactive after July 27, 2015)]

Dale, can you please uplift to 2.2?

Comment 13

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8560381 [details] [review]
[PullReq] mancas:bug1127743 to mozilla-b2g:v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Text Selection
[User impact] if declined: The user can select a non-selectable text
[Testing completed]: No need, just a CSS change
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]:None

Comment 14

[Dale Harvey (:daleharvey)]

Uplifted to 2.2

https://github.com/mozilla-b2g/gaia/commit/4351990120f572dcfa82a1376117e947c2ff2d75

Comment 15

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: The search suggestions message could not be selected.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150305010212
Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gecko: 56492f7244a9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150305002528
Gaia: 89af288bad6751248ff84504fa898206fee127fe
Gecko: 6d8d294aa8f3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0