1127899 - (SQLite3.8.8.2) Upgrade to SQLite 3.8.8.2

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

+++ This bug was initially created as a clone of Bug #1122717 +++

This version only includes one change:

- Enhance sqlite3_wal_checkpoint_v2(TRUNCATE) interface so that it truncates the WAL file even if there is no checkpoint work to be done.

I need this for some IndexedDB work I'm doing.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=983fb38c9ba3

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8557146 [details] [diff] [review]
Patch

Review of attachment 8557146 [details] [diff] [review]:
-----------------------------------------------------------------

::: db/sqlite3/README.MOZILLA
@@ +1,1 @@
> +This is SQLite 3.8.8.2

what about we finally change this to:

This is the Sqlite amalgamation.
Check sqlite3.h for the version number and source id.

So we can stop editing this file for each version

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sold!

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b40b4a20e62c

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b40b4a20e62c

Comment 6

[Arthur K. (he/him)]

SQLite 3.8.8.3 has been released.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

> Fix a bug (ticket 2326c258d02ead33) that can lead to incorrect results if the qualifying constraint of a partial index appears in the ON clause of a LEFT JOIN. 

Not sure if that warrants us bothering with an update. Mak?

Comment 8

[Marco Bonardo [:mak]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> > Fix a bug (ticket 2326c258d02ead33) that can lead to incorrect results if the qualifying constraint of a partial index appears in the ON clause of a LEFT JOIN. 
> 
> Not sure if that warrants us bothering with an update. Mak?

I think we'll skip for now. The bogus case is limited, and they say it also affects older versions (SQLite 3.8.0 and later), so we would have already noticed issues.