Closed
Bug 1128374
Opened 9 years ago
Closed 9 years ago
Largest icon size is wrong in manifest: it does not fit the real icon size
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: oteo, Unassigned)
References
Details
(Whiteboard: [loop approved for 1.1.1][In 1.1.1])
Attachments
(1 file)
The largest icon is 168px and the manifest says it is 187px. We should change the manifest to show the real icon size: "168": "/style/images/icons/Icon_Hello@2.png"
|
||
Comment 1•9 years ago
|
||
Attachment #8557701 -
Flags: review?(crdlc)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8557701 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/543 perfect, you're right
Attachment #8557701 -
Flags: review?(crdlc) → review+
|
|
||
Comment 3•9 years ago
|
||
in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/3f241637fca2d9bc379d52ab75a2fe14c0bd4afb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
Reporter | |
Updated•9 years ago
|
Whiteboard: [loop approved for 1.1.1]
|
|
||
Comment 4•9 years ago
|
||
in 1.1.1 https://github.com/mozilla-b2g/firefoxos-loop-client/commit/cc62392b796859ec837bc4febd2671f0618764aa
|
|
Reporter | |
Updated•9 years ago
|
Blocks: Loopmov_1_1_1
Whiteboard: [loop approved for 1.1.1] → [loop approved for 1.1.1][In 1.1.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•