Closed
Bug 1128479
Opened 9 years ago
Closed 9 years ago
Update Crypto.webidl to recent interface changes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
()
Details
Attachments
(2 files)
2.27 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
4.53 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The interface was updated a few months ago: https://dvcs.w3.org/hg/webcrypto-api/rev/810285715051
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8557883 [details] [diff] [review] 0001-Bug-1128479-Update-Crypto.webidl-to-recent-interface.patch >+interface GlobalCrypto { >+ //[Throws] readonly attribute Crypto crypto; >+ [Throws] readonly attribute nsIDOMCrypto crypto; You want Crypto as the type. > > // https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html >-partial interface Window { >- //[Throws] readonly attribute Crypto crypto; >- [Throws] readonly attribute nsIDOMCrypto crypto; >-}; ... but I guess since it is nsIDOMCrypto here, fine. But that really should be fixed. no nsIDOM* in .webidl, please. Currently nsIDOMCrypto seems to be the only nsIDOM* in any .webidl file.
Attachment #8557883 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8557915 -
Flags: review?(bugs)
Comment 4•9 years ago
|
||
Comment on attachment 8557915 [details] [diff] [review] 0002-Bug-1128479-Don-t-use-nsIDOMCrypto-in-Crypto.webidl.patch >+Crypto* > nsGlobalWindow::GetCrypto(ErrorResult& aError) > { > FORWARD_TO_INNER_OR_THROW(GetCrypto, (aError), aError, nullptr); > > if (!mCrypto) { > mCrypto = new Crypto(); >- mCrypto->Init(this); >+ nsCOMPtr<nsIDOMCrypto> domCrypto(mCrypto); >+ domCrypto->Init(this); Why you need domCrypto? Init doesn't do anything which might change mCrypto to point some other object, so mCrypto->Init(this); should work. Thanks.
Attachment #8557915 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #4) > > mCrypto = new Crypto(); > >- mCrypto->Init(this); > >+ nsCOMPtr<nsIDOMCrypto> domCrypto(mCrypto); > >+ domCrypto->Init(this); > > Why you need domCrypto? > Init doesn't do anything which might change mCrypto to point some other > object, so > mCrypto->Init(this); should work. Yeah, you're right. Got confused it seems. Thanks!
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea48f65afe64 https://hg.mozilla.org/integration/mozilla-inbound/rev/d02b6575d969
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ea48f65afe64 https://hg.mozilla.org/mozilla-central/rev/d02b6575d969
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•