1128719 - OSX DevEdition Theme: Pinned tab with overflowing tabs covers up the nav-bar box shadow

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: pinned-tab-border.png

See the screenshot and that the box shadow along the nav bar is interrupted by the pinned tab.  This appears to be OSX only.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: pinned-overflow-fix.patch

Oddly, setting position:fixed here [0] is causing the background of the tab to overlap the negative box shadow on the nav-bar [1] added in Bug 1097595.  To fix this, we can remove the background on the tab anyway, since it matches the tab bar.

Note, this won't be true for Windows after Bug 1093820, but we can just set the background color on tabs only for Windows there, especially since it doesn't suffer from this bug.

[0]: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#178
[1]: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#245

Comment 2

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/b597830d7034

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b597830d7034

Comment 4

[[e-mail]]

This is now fine in my  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0