1129158 - Persist Firefox Account credentials to user's profile

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1126584 embedded a login flow via accounts.firefox.com.  The next step is to persist the account credentials and configuration... somewhere.

Some of this stuff is confidential: sessionToken and (wrapped) keys.  Does it go in the keychain?  The sessionToken is per-device and should not be synced via iCloud.  Is that an issue?

Some of this stuff is configuration: service endpoints, etc.

Some of this stuff is transient: signed certificates that will expire, timestamped tokens, etc.

Presumably this all needs to be per-profile (so that, in theory, we can support profile switching).

This ticket tracks research into where to store things and then implementing the storage interface.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/135

bnicholson: st3fan already looked at most of the code move/remove patches.  Could you look over the last few, as described at https://github.com/mozilla/firefox-ios/pull/135#issuecomment-73334165?

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8565818 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/135

Looks good to me!

Comment 3

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/c53df6c7c33ec0ed5c4edd4eec8cc0d03856e7df