1129317 - SystemMessageInternal 1423035594631 : Unknown pendingPromise messageID. This seems a bug!!

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

While debugging bug 1126119 I found these error messages

I/Gecko   ( 3083): -- SystemMessageInternal 1423035594464 : received SystemMessageManager:GetPendingMessages activity for app://gallery.gaiamobile.org/index.html#pick @ app://gallery.gaiamobile.org/manifest.webapp
I/Gecko   ( 3083): -- SystemMessageInternal 1423035594631 : received SystemMessageManager:HandleMessageDone activity with msgID undefined for app://gallery.gaiamobile.org/index.html#pick @ app://gallery.gaiamobile.org/manifest.webapp - promise rejected: false
I/Gecko   ( 3083): -- SystemMessageInternal 1423035594631 : Unknown pendingPromise messageID. This seems a bug!!

Which seems caused by http://mxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessageInternal.js?rev=f15ef701bdf2#500

I'm not sure if this is real issue. fabrice?

Comment 1

[[:fabrice] Fabrice Desré]

That's from baku's latest changes (see http://mxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessageInternal.js?rev=f15ef701bdf2#785)

Andrea? "This seems a bug!!"

Comment 2

[Andrea Marchesini [:baku]]

kanru, can you reproduce this issue 100% of the times?
Do you have a small test I can use it?

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

I could reproduce it 100% of the times. Just uncomment the debug function in SystemMessageInternal.js and launch any app with activity. For example, I long tap the homescreen background and choose the Gallery app to choose background.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: id.patch

We need the msgID also when the GetPendingMessages is called.
It doesn't seem that the messageID is used anywhere else, so it should not be a problem to keep it and send it to the child.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: id.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11d06a2a6747

If green, checkin-needed.

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

Andrea, the latest patch seems to contain unintended modifications to Blob.cpp

Comment 7

[Andrea Marchesini [:baku]]

Yeah... I did mix 2 patches in one. Here the new try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e5531980e4d
I'll mark this bug checkin-needed if this is fully green.

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7accb67a2e6f

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7accb67a2e6f