1129507 - Honor DNT for Loop analytics

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Comment 1

[Adam Roach [:abr]]

Attachment: Honor DNT for Loop analytics

Untested, but this should be all it takes.

Comment 2

[Adam Roach [:abr]]

Attachment: Honor DNT for Loop analytics

Comment 3

[Adam Roach [:abr]]

Comment on attachment 8559237 [details] [diff] [review]
Honor DNT for Loop analytics

Mark: I'm not going to have the cycles to test that this works, and we really want to get it into the 0.13.4 release, but it's a really simple change. Can I have you run this through its paces (basically, run with DNT turned on and make sure nothing touches the google servers), and put an r+ on it?

If there's an issue with the code as-is, I'd like to hand ownership off to you or someone else on the team for fixing and landing.

Thanks!

Comment 4

[Adam Roach [:abr]]

After some further digging, it appears that this is well-worn ground, and that the use of Google Analytics isn't "tracking" in the sense that DNT encompasses. Rather than attempting to summarize the nuance here, I'll point to this email thread on governance:

https://groups.google.com/forum/?hl=en&fromgroups=#!search/mozilla$20governance$20google$20analytics/mozilla.governance/9IQvIubDOXU/0tWVVlrUJOQJ

Also of relevance are Bug 697436 comment 14 and Bug 858839 comment 18.

As our usage appears to be within the bounds of existing Mozilla policy and practices, the changes proposed by this bug are unnecessary. I'm closing as WONTFIX.

Comment 5

[Adam Roach [:abr]]

Based on input from our privacy folks, we're going to want to land this in the client as time allows. The current release would be ideal, but deferring to the next would be acceptable.

Comment 6

[Mark Banner (:standard8)]

Attachment: Honor DNT for Loop analytics.

I've now tested this across FF, Opera, Chrome & Safari - unfortunately there's a few different
ways that DNT is implemented, hence we need more than just one check. This catches all the major browsers and hopefully should catch any others we need.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8561327 [details] [diff] [review]
Honor DNT for Loop analytics.

I don't mind who reviews this, whoever is first is fine.

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8561327 [details] [diff] [review]
Honor DNT for Loop analytics.

Review of attachment 8561327 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 9

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/e9a2ce8b8586

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e9a2ce8b8586

Comment 11

[Chris More [:cmore]]

In my opinion, the conditional statement for excluding GA when DNT signal is turned on should be ignored for browsers that are shipped from the factory with DNT on as it does not signal user intent. Namely IE10 should be ignored: http://en.wikipedia.org/wiki/Do_Not_Track#Internet_Explorer_10_default_setting_controversy