1129598 - [RTL][Notification Tray] Opening Usage via Tray will open Whitescreen App, can close via Tray; locking in whitescreen will pitfall phone

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P1)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150204_1136.txt

Description:
In an RTL language, the user may reach a pitfall state via navigation of the Notification Tray. Accessing usage via the tray will load up a whitescreen app that, if killed via Task Manager, cannot be navigated away via 'Home' button. Using the notification tray, the user may recover from this app. However if the user were to lock their phone within that app, they will become blocked, as the user may not access the tray from lockscreen, nor seemingly unlock the phone.


Repro Steps:
1) Update a Flame to 20150204010225
2) Open the 'Settings' app.
3) Locate 'Languages'.
4) Change to a RTL language (documented in Arabic.)
5) Slide down Notification Tray from top of screen.
6) Tap SIM Widget near bottom to open usage.
7) Observe whitescreen.
8) Kill app via task manager.
9) Lock phone.

Actual:
7) Spawns whitescreen app, confusing to the user.
9) User reaches pitfall, must pull battery to recover.

Expected:
SIM Widget spawns Usage app without whitescreen.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150204010225
Gaia: dfebaaa8aab43470f482d09d71137bab840c3ae9
Gecko: 0c2f7434c325
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

--------------------------------------------------
Issue REPROES to an extent on flame 2.2 devices:
Results:
7) Spawns whitescreen app, confusing to the user.
- Can recover via homescreen, or killing the app (step 8).
9) User reaches pitfall, must pull battery to recover.
- This also occurs if locking when the whitescreen app is open.

BuildID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------

Repro frequency: 5/5
See attached: 
video- http://youtu.be/oRdhaqompvU
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

Nominating to block based upon pitfall scenario.

Comment 2

[Dylan Oliver [:doliver]]

triage: P1 to fix the launching of Usage app. 

I do see the white screen when entering Usage from the notification tray, but it returns normally to homescreen if I press home key or kill the Usage app. Also, if I press Home key to return to homescreen and then pull down notification try again, I can succeed when opening the Usage app from there on the second try.

Comment 3

[Josh Cheng [:josh]]

Dear Candice,
Could you help to find someone help for this bug? Thanks!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Francisco, is your team tracking this?

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Not yet, let's ask Salva if he is aware of this.

Salva is this familiar to you?

Comment 6

[Salvador de la Puente González [:salva]]

Can we try this again? I'm not reproducing the bug. What's happening to me with today's build (master Gaia) is:

  1. The new SIM message is appearing with proper RTL alignment (which is not seen in the attached video).
  2. When tapping on it, another application distinct than Cost Control is open but the Cost Control is still there, only not shown and accessible via task switcher.
  3. Once you access the Cost Control app, it is working well.

Can we test the STR again, please?

Comment 7

[Brogan Zumwalt [Inactive]]

Issue DOES occur on latest Flame 3.0 Master

Following STR in comment 0 this issue reproduces. When opening Cost Control from utility tray a grey screen appears (status bar is still visible.) Long pressing home button reveals that the current app is cost control. Sliding up to kill cost control and then, without exiting task manager, locking screen by short pressing power button results in user being presented with inescapable white screen when user turns screen on again. User must pull battery to exit this screen.

Device: Flame 3.0 Master
BuildID: 20150213010213
Gaia: 2a2b008f9ae957fe19ad540d233d86b5c0b6829e
Gecko: 2f5c5ec1a24b
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 8

[David Scravaglieri [:scravag]]

Could we have an update on this please ?

Comment 9

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to David Scravaglieri [:scravag] from comment #8)
> Could we have an update on this please ?

Unfortunately I'm not gonna be able to continue working on this.

Comment 10

[Stephany Wilkes]

The day of Feature Landing is not the day that it's acceptable to say we're no longer working on a P1 for 2.2 that is blocking the release and try to have it reassigned. Flagging Loic on this one. 

Flagging Gregor to see if we have anyone who can take this.

Comment 11

[Gregor Wagner [:gwagner]]

(In reply to Stephany Wilkes from comment #10)
> The day of Feature Landing is not the day that it's acceptable to say we're
> no longer working on a P1 for 2.2 that is blocking the release and try to
> have it reassigned. Flagging Loic on this one. 
> 
> Flagging Gregor to see if we have anyone who can take this.

Cost control is not part of systems-fe. back to comment 4.

Comment 12

[Stephany Wilkes]

I'll talk to Candice. This is more about notification tray than Cost Control, and I know of no one not in Taipei and on CNY who can take this.

Comment 13

[Stephany Wilkes]

Francisco, Candice pointed me to you: is there anyone you can think of who may be able to help during Chinese New Year? Thanks!

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

I've been talking with Marina, part of the Telefonica team that implemented Cost Control.

She has been taking a look to the issue and says that it's a window management problem, cc is not even launched.

ni her to give more information about it.

Comment 15

[Marina Rodríguez [:mai]]

Hi, 
I was testing this bug, IMHO it's a window management problem because:
  * If I don't kill the App when the white screen appears, and I only minimize it, I can see on the left side of the homescreen a vertical layer (screenshot is attached). This layer is hidden or showed depending on the language. (It's visible on RTL languages and hidden on other languages like English).
  * If I go to the settings, sliding down the utility tray, and pressing the settings button, when the White screen is showed, it desappears and all is correctly shown.

I hope this can be useful, for all this, I've changed the component to Windows management.

Best regards, 
Marina

Comment 16

[Marina Rodríguez [:mai]]

Attachment: Afterminimize.PNG

Comment 17

[David Scravaglieri [:scravag]]

Etienne, Alive, Mike, could you please comment on Marina ?
Thanks.

Comment 18

[Etienne Segonzac (:etienne)]

Reproducing the issue here and seeing system app errors in logcat... will have a look today!

Comment 19

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Etienne Segonzac (:etienne) from comment #18)
> Reproducing the issue here and seeing system app errors in logcat... will
> have a look today!

This is in good hands.

Comment 20

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1129598 > mozilla-b2g:master

Comment 21

[Etienne Segonzac (:etienne)]

Comment on attachment 8570734 [details] [review]
[gaia] etiennesegonzac:bug-1129598 > mozilla-b2g:master

Everything is bad and we should feel bad ;)

* because of a double click handler the cost control widget sends 2 MozActivity requests at the same time to open its own app
* the window manager then errors because it's not hardened against this edge case
* the costcontrol app finally opens and reflows constantly ~60 time per second because of a building block animation on <progress> (I bisected, it has been like that for almost a year! (bug 997084))
* and an rtl-only gfx glitch causes the findmyphone app (completely white) to display on top of everything else

This fixes it.

Comment 22

[Kevin Grandon :kgrandon]

Comment on attachment 8570734 [details] [review]
[gaia] etiennesegonzac:bug-1129598 > mozilla-b2g:master

I unfortunately won't be able to manually test this soon as I forgot my sim card at home, but this looks simple enough that I feel fine adding an R+ here. Looks like a pain to track this stuff down, nice job.

Comment 23

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/1968f8e1d37131a66a8ebdad2626da7f2b14d864

Comment 24

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: Usage app appears properly when opened via notification tray.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150303010233
Gaia: c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gecko: 0b3c520002ad
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

==================================
Leaving verifyme for 2.2 uplift/verification.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 26

[Etienne Segonzac (:etienne)]

Comment on attachment 8570734 [details] [review]
[gaia] etiennesegonzac:bug-1129598 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): probably a gfx rtl bug
[User impact] if declined: a completely white window can get stuck on top of everything else on screen
[Testing completed]: the STR from the bug + the patch has been on master for while without any issue
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 27

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/cb3d1887cff3539ad7654a65439d93b67037832c

Comment 28

[Sue]

Attachment: verify_pass.3gp

This issue has been verified as "Pass" on latest build of Flame 2.2 by STR in comment 0.
Result: Usage app appears properly when opened via notification tray.
See attachment: verify_pass.3gp
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.040422
Firmware Date          Wed Jun 17 04:04:34 EDT 2015
Bootloader             L1TC000118D0