1129640 - [Contacts] - The font on the contact information page listing the Birthday and Anniversary is way too small.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Joshua Mitchell (Inactive)]

Attachment: 2015-02-04-13-22-53.png

Description:
In the contact app when creating or editing a contact there is an option to add a contact's birthday or anniversary. If you do so, this info will show up in the contact's details page but the date for either listing is way too small compared to the rest of the font sizes.

Repro Steps:
1) Update a Flame to 20150204010225
2) Launch Contact App
3) Create a contact with a birthday and anniversary date info
4) View that contact's details page

Actual:
Font for Birthday and anniversary is way too tiny

Expected:
Normal sized font

Environmental Variables:
Device: Flame 3.0
Build ID: 20150204010225
Gaia: dfebaaa8aab43470f482d09d71137bab840c3ae9
Gecko: 0c2f7434c325
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Repro frequency: 5/5
See attached: screenshot
--------------------------------------------------------------------------------------------------------
This issue does NOT reproduce in 2.2 

Device: Flame 2.2 (KK - Nightly - Full Flash)
Build ID: 20150202002507
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: be206fa2fb60
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18d-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Visual regression of a core feature, poor UX.

Requesting a window.

Comment 2

[Johan Lorenzo [:jlorenzo]]

A regression window might not be necessary here. What do you think, Francisco?

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Agree don't think we need the regression window.

Johan, do you think is bad enough for being a blocker?

Comment 4

[Johan Lorenzo [:jlorenzo]]

To me, it would be a blocker.

Triage: Nice to have, not bad enough to hold the current 3.0 release.

Comment 5

[Maria Angeles Oteo (:oteo)]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> To me, it would be a blocker.

it's an ugly regression, let's try to fix it and ask for approval to 2.2 branch.

Adrian, can you have a look at it, please? Thanks a lot!

Comment 6

[Adrián de la Rosa]

Regression due to css change in bug 1058790. This is a RTL issue so let's ask Francisco how we should handle this field and add this bug to the RTL meta bug. In the worst case, we can just add a css rule to fix this case.

Comment 7

[bhavana bajaj [:bajaj]]

Looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1058790 was uplifted, so it may happen in 2.2 as well, hence changing the status.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Confirmed on 2.2. The issue appears on:
Build ID               20150216162504
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/78d823f7be4c
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150216.201649
Firmware Date          Mon Feb 16 20:17:00 EST 2015
Bootloader             L1TC000118D0

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Hi Adrian, as this has been uplift to 2.2, can you provide a patch for solving both situations?

Comment 10

[Adrián de la Rosa]

Ok, I'm taking it!

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] ADLR-es:rtl-css-fix > mozilla-b2g:master

Comment 12

[Adrián de la Rosa]

Comment on attachment 8566557 [details] [review]
[gaia] ADLR-es:rtl-css-fix > mozilla-b2g:master

Really minimal CSS fix.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

This is not an RTL specific bug, it's happening for LTR too and it's been already triaged.

Fix seems really simple, so we will ask for approval 2.2

Comment 14

[Jose Manuel Cantera]

Comment on attachment 8566557 [details] [review]
[gaia] ADLR-es:rtl-css-fix > mozilla-b2g:master

thanks Adrian

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f3ccc4c0edb0e0ebc9ea0bac3bb0ef4799554651

Comment 16

[Adrián de la Rosa]

Comment on attachment 8566557 [details] [review]
[gaia] ADLR-es:rtl-css-fix > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1058790
[User impact] if declined: The dates in the contact detail view will be rendered too small.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Very low, just a small CSS fix to re-enable some CSS rules.
[String changes made]: None

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d995adddf950107357b9072ad05716f0c979b90f

Comment 18

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: The Birthday and Anniversary appear in a normal size font.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150319010201
Gaia: c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gecko: cf1060d8ce9f
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150319002500
Gaia: 9043c11f699c15bb6072422d1dad6518d1b5ddda
Gecko: c0442d170bec
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0