1129786 - Unlazify initialization of some PLDHashTables

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nicholas Nethercote [inactive]]

In bug 700914 and bug 1059056 we lazified the initialization of some PLDHashTables in cases where the tables often never had anything put into them. This avoided some unnecessary allocations.

But now that bug 1050035 has landed, PLDHashTable does this optimization itself, and we can simplify things by undoing the previous patches.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

Now that empty PLDHashTables don't allocate any entry storage, we can undo the lazification of RuleHash::m*Table from bug 700914. r=bz.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

Now that empty PLDHashTables don't allocate any entry storage, we can undo the
lazification of nsDOMAttributeMap::mAttributeCache from bug 1059056.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Instantiate RuleHash::m*Table eagerly

fix up the log message

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8559586 [details] [diff] [review]
(part 2) - Instantiate nsDOMAttributeMap::mAttributeCache eagerly

r=me

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8559590 [details] [diff] [review]
(part 1) - Instantiate RuleHash::m*Table eagerly

r=me

Comment 6

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3d84265b196

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f75beaf3149f
https://hg.mozilla.org/integration/mozilla-inbound/rev/327a93e5cc39

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f75beaf3149f
https://hg.mozilla.org/mozilla-central/rev/327a93e5cc39