Closed
Bug 1129830
Opened 9 years ago
Closed 9 years ago
[RTL][Settings]Back button is reversed on Change PIN view.
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P2)
Tracking
(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: lulu.tian, Assigned: arthurcc)
References
Details
Attachments
(4 files)
[1.Description]: [RTL][Settings]When you go to the Change PIN view, the back button in header is reversed. See attachment:backbutton.png [2.Testing Steps]: Prerequisite: Insert two SIM card with PIN. 1. Set system language as Arabic. 2. Launch Settings -> SIM Manager -> SIM Security -> Change PIN. [3.Expected Result]: 2. The back button should display as "<". [4.Actual Result]: 2. The back button displays as ">" in header. [5.Reproduction build]: Flame 2.2 build: Build ID 20150204002509 Gaia Revision a4c4cc86303a554facb8f45b7e764e5c4473c3de Gaia Date 2015-02-04 00:41:59 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8669c26fd4a5 Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150204.035932 Firmware Date Wed Feb 4 03:59:42 EST 2015 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test
Bug 1115173 said "Back button is reversed when managing networks", and that bug is verified pass. This bug for tracing back button of Change PIN view.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → arthur.chen
Status: NEW → ASSIGNED
There is a same problem in Settings. When you insert a China SIM card and launch Settings -> USIM卡应用, then select any options under USIM卡应用, the back button displays as ">" in header. Add this case to this bug for further reference. See attachment:2015-02-06-11-07-31.png Flame 2.2 build: Build ID 20150205002503 Gaia Revision c2047a46e29696238e9b4c9caaba47736421449a Gaia Date 2015-02-04 20:34:04 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/adfba0a07e9b Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150205.045043 Firmware Date Thu Feb 5 04:50:54 EST 2015 Bootloader L1TC000118D0
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8560234 [details] [review] [PullReq] crh0716:1129830 to mozilla-b2g:master EJ, could you help review this simple patch? Thanks.
Attachment #8560234 -
Flags: review?(ejchen)
Updated•9 years ago
|
feature-b2g: --- → 2.2+
Priority: -- → P2
Comment on attachment 8560234 [details] [review] [PullReq] crh0716:1129830 to mozilla-b2g:master Thanks Arthur, this patch looks nice to me ! r+
Attachment #8560234 -
Flags: review?(ejchen) → review+
(In reply to Sue from comment #2) > Created attachment 8560222 [details] > 2015-02-06-11-07-31.png > > There is a same problem in Settings. > When you insert a China SIM card and launch Settings -> USIM卡应用, then select > any options under USIM卡应用, the back button displays as ">" in header. Add > this case to this bug for further reference. > See attachment:2015-02-06-11-07-31.png > > Flame 2.2 build: > Build ID 20150205002503 > Gaia Revision c2047a46e29696238e9b4c9caaba47736421449a > Gaia Date 2015-02-04 20:34:04 > Gecko Revision > https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/adfba0a07e9b > Gecko Version 37.0a2 > Device Name flame > Firmware(Release) 4.4.2 > Firmware(Incremental) eng.cltbld.20150205.045043 > Firmware Date Thu Feb 5 04:50:54 EST 2015 > Bootloader L1TC000118D0 Hi Sue, if this problem still exists, please file another bug for this item. Thanks !
Flags: needinfo?(lulu.tian)
Assignee | ||
Comment 7•9 years ago
|
||
Thanks, EJ. master: 857a0c89588df142718a64e63ed94fa2bd025868
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Resolution: --- → FIXED
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8560234 [details] [review] [PullReq] crh0716:1129830 to mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): N/A [User impact] if declined: Bad user experience [Testing completed]: Test on the device [Risk to taking this patch] (and alternatives if risky): Low as the patch did not change the code. [String changes made]: None
Attachment #8560234 -
Flags: approval-gaia-v2.2?
(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #6) > Hi Sue, if this problem still exists, please file another bug for this item. > Thanks ! Hi EJ, This bug still exists, I had opened a new bug, see Bug 1130965.
Flags: needinfo?(lulu.tian)
Updated•9 years ago
|
Attachment #8560234 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 10•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/d12ce89bbbb39356a3263a0dfeb537c9145acfaa
Target Milestone: --- → 2.2 S6 (20feb)
Comment 11•9 years ago
|
||
This issue is verified fixed on Flame 3.0 and on Flame 2.2. Back button on SIM PIN change screen is now pointing to the correct direction (left). See screenshot. Device: Flame 3.0 Master BuildID: 20150211010216 Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7 Gecko: ee093ca70666 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0 Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Device: Flame 2.2 BuildID: 20150211123004 Gaia: 791e53728cd8018f1d7cf7efe06bbeb1179f0370 Gecko: 84648f56b4d7 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
QA Whiteboard: [rtl-impact] → [rtl-impact][QAnalyst-Triage?]
Updated•9 years ago
|
Flags: needinfo?(ktucker)
Updated•9 years ago
|
QA Whiteboard: [rtl-impact][QAnalyst-Triage?] → [rtl-impact][QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Comment 12•9 years ago
|
||
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15585/
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•