Closed Bug 1129857 Opened 9 years ago Closed 9 years ago

Update timezones to 2015a

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
4.0.0.1

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

(Whiteboard: [see https://bugzil.la/1009894#c33 for a workaround to update timezones])

Attachments

(1 file)

Attached patch 2015a.diff — — Splinter Review
Filing this, not only because it needs to be done, but because it's so easy.
Attachment #8559715 - Flags: review?(philipp)
Comment on attachment 8559715 [details] [diff] [review]
2015a.diff

Review of attachment 8559715 [details] [diff] [review]:
-----------------------------------------------------------------

Thats all that changed between 2014j and 2015a? Looking at the changelog it sounds like there were more changes, and looking at the code it just looks like those timezones no longer have DST, since the BEGIN:DAYLIGHT component is missing?
Those are all the changes that affect us. I was confused when I saw the missing DST too, but according to tz-announce that's what's happening.
Status: NEW → ASSIGNED
Comment on attachment 8559715 [details] [diff] [review]
2015a.diff

Review of attachment 8559715 [details] [diff] [review]:
-----------------------------------------------------------------

Ok go.
Attachment #8559715 - Flags: review?(philipp) → review+
https://hg.mozilla.org/comm-central/rev/66f961f8ac26
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
Assignee: nobody → geoff
Whiteboard: [see https://bugzil.la/1009894#c33 for a workaround to update timezones]
Not all broken timezones was fixed with the patch
https://hg.mozilla.org/comm-central/rev/66f961f8ac26

All timezones should be patched, otherwise it's incorrect to mark issues like https://bugzilla.mozilla.org/show_bug.cgi?id=1090082 as dupluicate of this bug
Dmitriy, what timezones are still broken in Lightning 4.0 Beta?

The patch mentioned above only covers the update from 2014j release of tz data to the 2015a release. Russia timezones were changed with the earlier 2014f release and were already changed with the update to 2014j release in Bug 1121415.
In addition there is a timezones extension based on 2015a release attached Bug 1009894 that you can install in Thunderbird if you want the updated timezones for older releases like Lightning 3.3.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: