1130746 - [Mac][10.10] Window controls missing in full screen mode

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Nightly vs Release

The current Nightly builds are missing the window controls when a window is in full screen mode on OS X 10.10. See attachment for a comparison of Release and Nightly channels.

Comment 1

[Markus Stange [:mstange]]

I think this is a regression from bug 1120917.

Comment 2

[Markus Stange [:mstange]]

Attachment: patch

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8561208 [details] [diff] [review]
patch

Looks good to me.

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d85dce8ab6e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d85dce8ab6e

Comment 7

[Markus Stange [:mstange]]

Attachment: aurora patch

We have a very similar problem on aurora, which is fixed by this patch: bug 1130733
Aurora doesn't have the patch for bug 1120917, that's why on Aurora the buttons are only slightly shifted instead of invisible.

Approval Request Comment
[Feature/regressing bug #]: Mac OS 10.10
[User impact if declined]: shifted window controls in full screen mode
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: very low
[String/UUID change made/needed]: none

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Markus Stange [:mstange] from comment #7)
> We have a very similar problem on aurora, which is fixed by this patch: bug
> 1130733
> Aurora doesn't have the patch for bug 1120917, that's why on Aurora the
> buttons are only slightly shifted instead of invisible.
> 
> Approval Request Comment
> [Feature/regressing bug #]: Mac OS 10.10

Many fixes for OSX 10.10 shipped in 34. Bug 1120917 was fixed in 38 and bug 1130733 was resolved as a dup of this bug. Do you know that bug that introduced the issue? Does this affect 36?

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8563183 [details] [diff] [review]
aurora patch

This is a branch specific patch for Aurora that has a different fix than that required for Nightly. We'll need to verify the patch on Aurora. Aurora+

Comment 10

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:

FF 38 BUILD ID: 20150211222327
Mac Os x 10.10

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/89469f4ebfb0

Comment 12

[Markus Stange [:mstange]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #8)
> (In reply to Markus Stange [:mstange] from comment #7)
> > We have a very similar problem on aurora, which is fixed by this patch: bug
> > 1130733
> > Aurora doesn't have the patch for bug 1120917, that's why on Aurora the
> > buttons are only slightly shifted instead of invisible.
> > 
> > Approval Request Comment
> > [Feature/regressing bug #]: Mac OS 10.10
> 
> Many fixes for OSX 10.10 shipped in 34. Bug 1120917 was fixed in 38 and bug
> 1130733 was resolved as a dup of this bug. Do you know that bug that
> introduced the issue? Does this affect 36?

I was assuming that we have always had the offset bug on 10.10, ever since we started shifting the buttons in the regular Firefox window (bug 851652). But now that I've tried to find a regression range, I noticed that I can't actually reproduce the shifted button problem, in any build. It's possible that the reporter of bug 1130733 only hit it due to a lucky coincidence. In any case, the patch is the right way to fix it in the cases that it does occur.

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #9)
> This is a branch specific patch for Aurora that has a different fix than
> that required for Nightly. We'll need to verify the patch on Aurora. Aurora+

Well, the fix is the same (adding a " && !([self styleMask] & NSFullScreenWindowMask)"), just the context has changed.

Comment 13

[Petruta Horea [:phorea], Desktop QA]

Reproduced using Nightly 38.0a1 2015-02-07.
Verified as fixed with Firefox 37 beta 1 under Mac OS X 10.10.