Closed Bug 1131505 Opened 9 years ago Closed 8 years ago

Running homescreen-manager.js on node.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(1 file)

      No description provided.
Priority: -- → P1
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment on attachment 8705955 [details] [review]
[gaia] rickychien:homescreen-manager-to-node > mozilla-b2g:master

Another simple path too. All of utils APIs used by homescreen-manager.js are stable now and I don't want try to use nodeHelper.require (so you don't have to ./diff.sh) here and just make sure all APIs are convert to utils common version.

Please help me review it again to ensure there has no crucial issue or unconverted utils APIs.
Attachment #8705955 - Flags: review?(scwwu)
Comment on attachment 8705955 [details] [review]
[gaia] rickychien:homescreen-manager-to-node > mozilla-b2g:master

Tested ok on a device and diff looks okay! r+
Attachment #8705955 - Flags: review?(scwwu) → review+
Landed

https://github.com/mozilla-b2g/gaia/commit/aac56169b9baaa9a82094b3c759e63fe4c7d491c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: