11316 - SaveMessageToDisk() call fails when message contains lines with CRLF ALONE

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P3)

Description

[rhp (gone)]

I was testing my SendLater operations and when I go to save the files off to
send them, I make the call:

rv = messageService->SaveMessageToDisk(aMessageURI, mHackTempIFileSpec,
                                       PR_FALSE, mSaveListener, nsnull);

Everything works callback wise, etc... but the file is truncated at the first
line with a CRLF only and my callback gets called with an error code.

Comment 1

[rhp (gone)]

Attachment: This is an example of a mail folder that shows problem

Comment 2

[Scott MacGregor]

Setting to M9.

Comment 3

[Scott MacGregor]

I'm having trouble with this attachment. When I save the file as text, the CRLFs
are getting messed up. It would take to long to reformat the message by hand so
I'm going to wait till rich can send me the attachment diretly without going
through bugzilla.

I'll tackle this first thing in the morning.

Comment 4

[Scott MacGregor]

Hey Rich, I just tested save message to disk on the folder you emailed me and it
worked like a charm. It wrote the message out in its entirety to disk without a
problem.

However, I did notice that the one you sent me was NOT the one you posted in
this bug report so it may not have the conditions necessary to generate the bug.
Hmm.

Comment 5

[Scott MacGregor]

I wasn't able to reproduce any problems with actually saving the message to
disk.

but there was a problem with necko where they are returning NS_STOP_BINDING
after I read a byte range from the file. This is defined as an error code but it
should be defined as a success code. I've been trying to get them to change that
for a couple weeks but it hasn't happened yet. I added a work around to hide it
until they can change the code.

Marking as fixed.

Comment 6

[lchiang]

Par, pls verify.

Comment 7

[ppandit]

In mailnews/base/public/nsIMessageService.idl, the function is
void SaveMessageToDisk(in string aMessageURI, in nsIFileSpec aFile,
                            in boolean aGenerateDummyEnvelope,
                            in nsIUrlListener aUrlListener, out nsIURI aURL,
                            in boolean canonicalLineEnding);

Do you have a testcase available to verify this bug? Was there an attachment I
can load?

Par

Comment 8

[ppandit]

Forget the javascript idl stuff.
Using a debug build from 2/14/00 on Window NT 4.0

Set a breakpoint in two locations within nsMessagenger.cpp where the function is 
called.
Added the attachment from this bug report to a POP3 inbox file
Start mozilla and opened the Inbox 
Saved the message as a file into a temp directory.
Opened message in notepad - everything looked good. 
Did a visual comparison with the original and saw no differences. 

MARKING AS VERIFIED. I assume the above procedure is correct for verification.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ccb9a9ac115
[components] For https://github.com/mozilla-mobile/android-components/issues/11316: Update leakcanary version to 2.8.1